Add support for PEP 604 (Union |) in stub files #924
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow! That really is a shockingly easy change. @martindemello Could you review this PR, since you wrote pyi/parser.py and are the most familiar with it? |
|
looks great, thanks for the fix! |
|
Great, I'll go ahead and import this PR. Thanks, Martin! |
rchen152
pushed a commit
that referenced
this pull request
May 17, 2021
rchen152
added a commit
that referenced
this pull request
May 17, 2021
Add support for PEP 604 (Union |) in stub files (#924)
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #785, though not a complete fix because this doesn't allow the
|syntax at runtime (I think).I was pleasantly surprised by how easy this change was. I hope that doesn't mean I missed something.