Main elf enhancement

[bpyeh]

Adds another Elf asset depicted after throwing the present, and a small state machine to model the action.

One subtle thing missing here is the overhead present doesn't disappear after throwing, but the action is quick enough that we can kind of get away with it.

[Jezzamonn]

I think this logic could probably be simplified by just having 1 variable, the animateCooldown. You could get rid of currentUserEvent and playerElfState and just update the logic to see if the animateCooldown is greater than 0 or not.

[bpyeh]

it's a bit of futureproofing - if we wanted a state for player elf diving into the cart to fetch another present this could easily be extended. I guess the currentUserEvent isn't adding too much, but I wanted to decouple the click callback from the update logic

[Jezzamonn]

So the reason behind the suggestion is to contain the state to as few variables as possible, and then calculate everything from that. It's possible for someone to make a change and put the variables in an invalid state at the moment, whereas if say you had a function that was getPlayerElfState() that just returned the state based on the animateCooldown then there's no way to set the playerElfState in a way that conflicts with the animateCooldown.

For the future proofing case, we'd apply the same logic - everything could be calculated from the animateCooldown, including which frame of the animation to play. I've used that approach in some of the games I've made in the past and it works well.

[bpyeh]

I see what you're saying. I'll try to get to this if I have time.

[Jezzamonn]

Leaving my approval so we can merge this in it's current state if needed!