Increase the precision for GA4 mock data generated floats.

google · Mar 6, 2023 · b264e84 · b264e84
1 parent 45e4b5f
commit b264e84
Show file tree

Hide file tree

Showing 2 changed files with 38 additions and 9 deletions.
diff --git a/assets/js/modules/analytics-4/utils/__fixtures__/mocked-report.json b/assets/js/modules/analytics-4/utils/__fixtures__/mocked-report.json
@@ -4,7 +4,10 @@
 	"maximums": [
 		{
 			"dimensionValues": [ { "value": "RESERVED_MAX" } ],
-			"metricValues": [ { "value": "89" }, { "value": "0.62" } ]
+			"metricValues": [
+				{ "value": "89" },
+				{ "value": "0.6174966930411756" }
+			]
 		}
 	],
 	"metadata": {
@@ -18,36 +21,57 @@
 	"minimums": [
 		{
 			"dimensionValues": [ { "value": "RESERVED_MIN" } ],
-			"metricValues": [ { "value": "55" }, { "value": "0.14" } ]
+			"metricValues": [
+				{ "value": "55" },
+				{ "value": "0.14262126828543842" }
+			]
 		}
 	],
 	"rowCount": 5,
 	"rows": [
 		{
 			"dimensionValues": [ { "value": "20201229" } ],
-			"metricValues": [ { "value": "55" }, { "value": "0.14" } ]
+			"metricValues": [
+				{ "value": "55" },
+				{ "value": "0.14262126828543842" }
+			]
 		},
 		{
 			"dimensionValues": [ { "value": "20201230" } ],
-			"metricValues": [ { "value": "3" }, { "value": "0.13" } ]
+			"metricValues": [
+				{ "value": "3" },
+				{ "value": "0.13729542959481478" }
+			]
 		},
 		{
 			"dimensionValues": [ { "value": "20201231" } ],
-			"metricValues": [ { "value": "17" }, { "value": "0.39" } ]
+			"metricValues": [
+				{ "value": "17" },
+				{ "value": "0.38743476173840463" }
+			]
 		},
 		{
 			"dimensionValues": [ { "value": "20210101" } ],
-			"metricValues": [ { "value": "10" }, { "value": "0.73" } ]
+			"metricValues": [
+				{ "value": "10" },
+				{ "value": "0.7306178859435022" }
+			]
 		},
 		{
 			"dimensionValues": [ { "value": "20210102" } ],
-			"metricValues": [ { "value": "89" }, { "value": "0.62" } ]
+			"metricValues": [
+				{ "value": "89" },
+				{ "value": "0.6174966930411756" }
+			]
 		}
 	],
 	"totals": [
 		{
 			"dimensionValues": [ { "value": "RESERVED_TOTAL" } ],
-			"metricValues": [ { "value": "89" }, { "value": "0.62" } ]
+			"metricValues": [
+				{ "value": "89" },
+				{ "value": "0.6174966930411756" }
+			]
 		}
 	]
 }
diff --git a/assets/js/modules/analytics-4/utils/data-mock.js b/assets/js/modules/analytics-4/utils/data-mock.js
@@ -122,7 +122,12 @@ function generateMetricValues( validMetrics ) {
 			case 'TYPE_FLOAT':
 				values.push( {
 					value: faker.datatype
-						.float( { min: 0, max: 1 } )
+						.float( {
+							min: 0,
+							max: 1,
+							// The GA4 API returns 17 decimal places, so specify that here, although it seems like Faker is only returning up to 16.
+							precision: 0.00000000000000001,
+						} )
 						.toString(),
 				} );
 				break;