-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove pre-WP5.2 PHP polyfill code, including test code #5875
Labels
Comments
felixarntz
added
P0
High priority
Type: Enhancement
Improvement of an existing feature
labels
Sep 21, 2022
IB ✅ |
Moving this to the next sprint and adding a note to the issue that this shouldn't be merged until |
nfmohit
added a commit
that referenced
this issue
Nov 8, 2022
QA Update: ✅Verified:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
🚨 Note: do not merge until Release
1.88.0
🚨Together with bumping the minimum WordPress version requirement to 5.2 (see #5874), we should remove any polyfill code that is only in Site Kit for WordPress versions lower than 5.2.
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
Implementation Brief
This can be started, but it must not be merged until
develop
is open for the 1.88.0 release. When you open a pull request for this issue, please add the same annotation to the top of the PR to minimize the chance of an accidental early merge. :)BC_Functions::rest_preload_api_request
andBC_Functions::load_script_textdomain
methods.packages/wp-phpunit-polyfill
directory and remove it as a dependency incomposer.json
.Test Coverage
QA Brief
Changelog entry
The text was updated successfully, but these errors were encountered: