-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce factory for Analytics 4 response mock data #6174
Comments
@FlicHollis As a note about the dependency here, it's more specific to one part of it (the |
Thanks so much for the additional context @aaemnnosttv |
Hey @hussain-t, the initial approach is looking good in the IB, but I think it would benefit from going into a little more detail on how to achieve the last point.
For example, the advice might be to refer to the metric & dimension mappings in the Phase 2 one-pager and the migration guide, update the mock metrics/dimensions as appropriate, and to remove those which are no longer relevant (i.e. the AdSense ones as GA4 isn't yet linked with AdSense). |
Thanks for pointing it out, @techanvil. I have updated the IB. |
Thanks @hussain-t! IB ✅ |
NOTE: This is a blocker for several issues in Sprint 92:
Please pick up this issue as early as possible in Sprint 92 to unblock these issues. Thank you! |
Feature Description
A
data-mock
set of utilities should be created for generating and receiving mock report data for use by theanalytics-4
data store, similar to what has been done foranalytics
,search-console
, andadsense
.Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
analytics-4/util/data-mock.js
module should be created, similar to the utilities by the same name for other modulesgetAnalytics4MockResponse( args )
– a pure function that generates a mock report in the same format that would be returned from the server backend for a report request with the givenargs
provideAnalytics4MockReport( registry, options )
– a pure function that generates and receives the resulting mock report data onto theanalytics-4
store of the given registryImplementation Brief
assets/js/modules/analytics-4/util/data-mock.js
.assets/js/modules/analytics/util/data-mock.js
toassets/js/modules/analytics-4/util/data-mock.js
.provideAnalyticsMockReport
toprovideAnalytics4MockReport
.getAnalyticsMockResponse
togetAnalytics4MockResponse
.MODULES_ANALYTICS
withMODULES_ANALYTICS_4
./analytics/i
with/analytics-4/i
.Test Coverage
assets/js/modules/analytics-4/util/data-mock.test.js
.getAnalytics4MockResponse
function.QA Brief
Changelog entry
The text was updated successfully, but these errors were encountered: