Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create GA4 AdminBarSessions #6215

Closed
aaemnnosttv opened this issue Nov 29, 2022 · 4 comments
Closed

Create GA4 AdminBarSessions #6215

aaemnnosttv opened this issue Nov 29, 2022 · 4 comments
Labels
Exp: SP P0 High priority Type: Enhancement Improvement of an existing feature

Comments

@aaemnnosttv
Copy link
Collaborator

aaemnnosttv commented Nov 29, 2022

Feature Description


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • A new component AdminBarSessionsGA4 should be created based on the existing AdminBarSessions
  • The component should source its report data from the analytics-4 store
  • No changes should be made in the dashboard yet
  • Storybook stories should be added to cover the following cases (with and without a current entity URL set: example):
    • Loading
    • Gathering data ("Data unavailable")
    • Zero data (data available but metric is 0)
    • Error
    • Ready (data available and non-zero)

Implementation Brief

Test Coverage

  • No new tests are to be added.

QA Brief

  • This is currently only testable in Storybook.
  • Check the stories under VIEWS > AdminBarApp > AdminBarSessionsGA4. These should be broadly in line with the existing UA version under VIEWS > AdminBarApp > AdminBarSessions, except with the following additional stories:
    • Loading
    • Error
  • PR Storybook (will be deleted when merged to develop).
  • develop Storybook.
  • main Storybook.

Screenshots

Screenshot 2023-02-22 at 3 13 01 PM
Screenshot 2023-02-22 at 3 13 08 PM
Screenshot 2023-02-22 at 3 13 14 PM
Screenshot 2023-02-22 at 3 13 20 PM
Screenshot 2023-02-22 at 3 13 31 PM

Changelog entry

  • Create Google Analytics 4 version of the AdminBarSessions widget.
@aaemnnosttv aaemnnosttv added P1 Medium priority Type: Enhancement Improvement of an existing feature labels Nov 29, 2022
@aaemnnosttv aaemnnosttv self-assigned this Nov 29, 2022
@aaemnnosttv aaemnnosttv removed their assignment Dec 9, 2022
@hussain-t hussain-t assigned hussain-t and unassigned hussain-t Dec 13, 2022
@techanvil techanvil self-assigned this Dec 19, 2022
@techanvil
Copy link
Collaborator

IB ✅

@techanvil techanvil removed their assignment Dec 19, 2022
@eclarke1 eclarke1 added P0 High priority and removed P1 Medium priority labels Dec 22, 2022
@asvinb asvinb self-assigned this Feb 2, 2023
@sashadoes sashadoes assigned sashadoes and unassigned sashadoes Feb 15, 2023
@hussain-t hussain-t self-assigned this Feb 20, 2023
@hussain-t hussain-t removed their assignment Feb 22, 2023
@techanvil techanvil assigned techanvil and hussain-t and unassigned techanvil Feb 22, 2023
@hussain-t hussain-t assigned techanvil and unassigned hussain-t Feb 23, 2023
@techanvil techanvil assigned hussain-t and unassigned techanvil Feb 24, 2023
@hussain-t hussain-t assigned techanvil and unassigned hussain-t Feb 24, 2023
techanvil added a commit that referenced this issue Feb 24, 2023
@techanvil techanvil removed their assignment Feb 24, 2023
@mohitwp mohitwp self-assigned this Feb 27, 2023
@mohitwp
Copy link
Collaborator

mohitwp commented Mar 1, 2023

QA Update ⚠️

@hussain-t In existing UA Story title is "Total Sessions" and for GA4 it is "Sessions" only. I'm not able to found any related reference in See here for a table of equivalent metrics for GA4 doc. Did we change title for GA4 AdminBarSessions ?

image

image

@hussain-t
Copy link
Collaborator

Thanks for raising this, @mohitwp. I changed it to Sessions as per the Google migration docs field name:

Screenshot 2023-03-02 at 2 09 03 PM

However, it should be kept the same since it wasn't in the design docs. I will make sure to create a follow-up PR to address it shortly.

@hussain-t hussain-t removed their assignment Mar 2, 2023
techanvil added a commit that referenced this issue Mar 2, 2023
Enhance/#6215 - Change admin bar sessions title (follow-up)
@mohitwp
Copy link
Collaborator

mohitwp commented Mar 2, 2023

QA Update ✅

  • Tested Storybook.

  • Compared AdminBarSessionsGA4 with AdminBarSessions.

  • Issue reported above now resolved.

  • Added storybook for below cases.

    • Loading
    • Gathering data ("Data unavailable")
    • Zero data (data available but metric is 0)
    • Error
    • Ready (data available and non-zero)

image

image

image

image

image

@mohitwp mohitwp removed their assignment Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Exp: SP P0 High priority Type: Enhancement Improvement of an existing feature
Projects
None yet
Development

No branches or pull requests

8 participants