Update Consent Mode once the Ads Conversion ID setting has been migrated to the Ads module.

[techanvil]

Feature Description

Ensure that the relevant parts of Consent Mode are updated once the Ads Conversion ID setting has been migrated to the Ads module.

Some of this will almost certainly be updated as part of the Ads Module work, this issue is to ensure nothing is missed.

---

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

• Once the Ads Conversion ID has been migrated to the Ads Module:
  • All references to it in the Consent Mode feature should be updated to use the value from the Ads Module.
  • The confirmation dialog shown when disabling Consent Mode on the Settings screen should be updated to include the Ads module when it's connected.

Implementation Brief

An initial IB has been drafted, to be completed.

• Ensure the following code snippets are updated to get the adsConversionID from the ads module:

site-kit-wp/assets/js/components/consent-mode/ConsentModeSetupCTAWidget.js

Lines 72 to 75 in 26e6a43

	const isAdsConnected = useSelect( ( select ) =>
	// TODO: Replace this with the `analytics-4` or `ads` version of the `getAdsConversionID()` selector once it's migrated.
	select( MODULES_ANALYTICS ).getAdsConversionID()
	);

site-kit-wp/assets/js/components/settings/SettingsCardConsentMode.js

Lines 50 to 53 in 26e6a43

	const isAdsConnected = useSelect( ( select ) =>
	// TODO: Replace this with the `analytics-4` or `ads` version of the `getAdsConversionID()` selector once it's migrated.
	select( MODULES_ANALYTICS ).getAdsConversionID()
	);

site-kit-wp/assets/js/components/consent-mode/ConfirmDisableConsentModeDialog.js

Lines 45 to 47 in 26e6a43

	const dependentModuleNames = useSelect( ( select ) =>
	// TODO: Add the Ads module to this list when the Ads Conversion ID is migrated to it.
	[ 'analytics-4' ].reduce( ( names, slug ) => {

Test Coverage

• Update the assets/js/components/consent-mode/ConsentModeSetupCTAWidget.stories.js story to use the ads store.

QA Brief

• Setup the Site Kit, enable adsModule feature flag, and connect Analytics and Ads modules
• Go to the Site Kit settings -> Admin Settings, enable the Consent Mode. Then try to disable it, the popup should mention Ads module in the Note section, together with Analytics "Note: these active modules depend on consent mode and will be affected: Analytics and Ads"
• Then disconnect the Ads module, and repeat the step above, note section should mention only Analytics as affected module (Ads should be in the list only when active)
• Verify that Consent mode banner is still appearing when Ads module is active, and not showing when Ads module is not connected
• Verify that recommended badge is showing in admin settings when Ads module is connected

Changelog entry

• Ensure that the check for a conversion tracking ID is maintained for the Consent Mode feature with the conversion ID having been migrated to the Ads module.

[benbowler]

I have reviewed the current consent mode for any use of the adsConversionID and all cases are covered in the IB.

[eugene-manuilov]

IB ✔️

[nfmohit]

Hi @zutigrm & @techanvil.

It looks like this change in the PR has stopped the consent mode banner from appearing if the Ads module is not connected.

The above change implies that the consent mode banner should only show up if both the Analytics & Ads modules are connected. However, it is possible for Google Ads to be connected even without one of the modules disconnected. Examples:

1. Analytics module is not connected, but Ads module is connected with an Ads conversion tracking ID.
2. Ads module is not connected, but Analytics module is connected and:
   1. It is linked with Google Ads (adsLinked) and/or
   2. The connected Google Tag has an Ads conversion ID as one of its destinations.

However, with the above linked change, the banner will only appear if both Ads and Analytics modules are connected, which I think is not right. Thoughts?

[techanvil]

Thanks @nfmohit, great spot. That one totally slipped by me.

@zutigrm, please can you file a followup PR to update the condition that Nahid's highlighted? It should be returning false if neither of the modules are connected, e.g. along these lines:

if (
  ! (
    isModuleConnected( 'analytics-4' ) || isModuleConnected( 'ads' )
  )
) {
  return false;
}

With this being a release issue we should address this as a priority. Thanks!

@mohitwp, I've moved this back from QA to Execution and assigned it back to Aleksej to address the above.

[techanvil]

Apologies, I hadn't spotted @zutigrm is off today. @nfmohit has kindly offered to raise a PR to address this.

[nfmohit]

Thanks @nfmohit, great spot. That one totally slipped by me.

@zutigrm, please can you file a followup PR to update the condition that Nahid's highlighted? It should be returning false if neither of the modules are connected, e.g. along these lines:

if (
  ! (
    isModuleConnected( 'analytics-4' ) || isModuleConnected( 'ads' )
  )
) {
  return false;
}

With this being a release issue we should address this as a priority. Thanks!

@mohitwp, I've moved this back from QA to Execution and assigned it back to Aleksej to address the above.

Thank you @techanvil . This is in CR now with a follow-up PR.

[techanvil]

Top stuff, thanks @nfmohit. The PR is now merged, back to you @mohitwp to continue the QA for this one.

[mohitwp]

QA Update ⚠️

• Tested on main environment.
• Hey @nfmohit , according to the QAB Consent mode, the banner only appears if the Ads module is connected, regardless of whether analytics is connected or not. I just want to confirm if this information is correct, especially if the QAB hasn't been updated after recent changes. Could you please review and confirm?

If only Analytics is connected

Both Analytics and Ads Module connected-

Only Ads module is connected -

Ads Module connected with Analytics

Ads Module connected without Analytics

Recommended badge -

Recommended badge not showing if analytics is not connected-

[nfmohit]

• Hey @nfmohit , according to the QAB Consent mode, the banner only appears if the Ads module is connected, regardless of whether analytics is connected or not. I just want to confirm if this information is correct, especially if the QAB hasn't been updated after recent changes. Could you please review and confirm?

Hi @mohitwp. That is correct. If the Ads module is connected, we don't need the Analytics module to also be connected in this context. Thanks!

[mohitwp]

QA Update ✅

• Tested on main environment.
• Verified according to the QAB Consent mode, the banner only appears if the Ads module is connected, regardless of whether analytics is connected or not.
• Verified Recommended badge is appearing only if Ads module is connected.
• Verified Copy under disconnect modal is getting update as per which module is active.

If only Analytics is connected

Both Analytics and Ads Module connected-

Only Ads module is connected -

Ads Module connected with Analytics

Ads Module connected without Analytics

Recommended badge -

Recommended badge not showing if analytics is not connected-