-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Ads bullet point from Consent Mode modal when Ads is not connected. #8381
Comments
IB ✔️ |
Hi @techanvil, we have updated the description copy to include "and the United Kingdom" as part of #8389. Could you confirm if, in the absence of the Ads conversion ID, the description should now read: "Disabling consent mode may affect your ability in the European Economic Area and the United Kingdom to"? Also, should the bullet point be revised to "Track how visitors interact with your site"? |
Hi @hussain-t, thanks for raising this. The copy should indeed be updated as you've pointed out. I've also realised the AC had become a bit out of date with regard to the conditions for determining if Ads is connected, and have updated it accordingly. Please can you ensure the implementation follows the AC? If you want to send it back to IB to ensure the IB is also aligned, please feel free to do so, but if you prefer to simply address this during execution that seems fine to me too. |
Thanks for the clarification, @techanvil. We don't need to move it to IB. I will address the changes in my PR. |
QA Update: ✅Verified: Ads Module Connected
Ads Module Disconnected
I tested this when:
|
Feature Description
When an Ads Conversion ID has not been set up, we should not show the "Performance of your Ad campaigns" bullet point in the disable modal (screenshots taken from Figma):
As a result the copy above the bullet points should also be updated, so the modal description and bullet point list should read as follows:
See also the related issue #8389.
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
Implementation Brief
assets/js/components/consent-mode/ConfirmDisableConsentModeDialog.js
:MODULE_ADS
store using thegetAdsConversionID
selector.useMemo
to return a newprovides
array based on the Ads Conversion ID's presence:provides
prop on theModalDialog
to take the newprovides
array:provides={ provides }
Test Coverage
QA Brief
Ads Module Connected
Settings->Admin Settings
page.Ads Module Disconnected
Settings -> Admin Settings
page.Changelog entry
The text was updated successfully, but these errors were encountered: