-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scroll to the Audiences Widget Area from the Setup Success Notice #8874
Comments
I created an IB, should we consider dismissing the notification after the user clicks "Show Me"? |
Thanks @benbowler, yes, the intention is to dismiss the notification as well (i.e. maintain the current behaviour). I've updated the AC to make it clearer. IB ✅ |
…l-area Scroll to audiences widget area
QA Update ✅Upon clicking the "Show me" CTA on the Setup Success Notice, the page scrolls to the Audiences Widget Area, and the notice is dismissed for the current user. Moving ticket to Approval.
Desktop test:
8874.-.Test.success.movMobile test: RPReplay_Final1726600586.MP4 |
Feature Description
Clicking on the Setup Success Notice's "Show me" CTA should scroll to the Audiences Widget Area.
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
Implementation Brief
Note: see the IB for #8172, we may be able to refactor/reuse the corresponding code.
scrollToWidgetArea
function inassets/js/modules/analytics-4/components/audience-segmentation/dashboard/AudienceSegmentationSetupSuccessSubtleNotification.js
:site-kit-wp/assets/js/modules/analytics-4/components/audience-segmentation/dashboard/AudienceSegmentationSetupSuccessSubtleNotification.js
Lines 65 to 70 in e12d144
getContextScrollTop
to get the y offset for the class.googlesitekit-widget-area--mainDashboardTrafficAudienceSegmentation
.global.scrollTo
withtop
set to the value ofgetContextScrollTop
and thebehaviour
set tosmooth
.dismissNotificationForUser
in this function.Test Coverage
QA Brief
audienceSegmentation
feature flag from the tester plugin.Changelog entry
The text was updated successfully, but these errors were encountered: