Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scroll to the Audiences Widget Area from the Setup Success Notice #8874

Closed
4 tasks
techanvil opened this issue Jun 14, 2024 · 3 comments
Closed
4 tasks

Scroll to the Audiences Widget Area from the Setup Success Notice #8874

techanvil opened this issue Jun 14, 2024 · 3 comments
Labels
Module: Analytics Google Analytics module related issues P1 Medium priority Team M Issues for Squad 2 Type: Enhancement Improvement of an existing feature

Comments

@techanvil
Copy link
Collaborator

techanvil commented Jun 14, 2024

Feature Description

Clicking on the Setup Success Notice's "Show me" CTA should scroll to the Audiences Widget Area.

image


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  • Upon clicking the "Show me" CTA on the Setup Success Notice, the page should scroll to the Audiences Widget Area, and the notice should be dismissed for the current user.

Implementation Brief

Note: see the IB for #8172, we may be able to refactor/reuse the corresponding code.

  • Update the scrollToWidgetArea function in assets/js/modules/analytics-4/components/audience-segmentation/dashboard/AudienceSegmentationSetupSuccessSubtleNotification.js:
    function scrollToWidgetArea() {
    dismissNotificationForUser();
    // TODO: Scrolling to the widget area will be implemented in a subsequent issue.
    }
    • Use getContextScrollTop to get the y offset for the class .googlesitekit-widget-area--mainDashboardTrafficAudienceSegmentation.
    • Use global.scrollTo with top set to the value of getContextScrollTop and the behaviour set to smooth.
    • Account for any layout shift due to the notification being dismissed with dismissNotificationForUser in this function.

Test Coverage

  • No additional test coverage required.

QA Brief

  • Turn on the audienceSegmentation feature flag from the tester plugin.
  • Set up Site Kit with the Analytics module.
  • In the Site Kit dashboard, click on "Enable groups" CTA in the Audience Segmentation setup CTA widget.
  • Upon success, click on the "Show me" CTA in the setup success notification.
  • Verify that you are scrolled to the audience widget area, and that the setup success notification is dismissed.

Changelog entry

  • Scroll to the Audiences Widget Area when clicking the "Show me" CTA on the Setup Success Notice that is shown when the Audience Segmentation feature has been set up.
@techanvil techanvil added Module: Analytics Google Analytics module related issues P1 Medium priority Type: Enhancement Improvement of an existing feature labels Jun 14, 2024
@ivonac4 ivonac4 added the Team M Issues for Squad 2 label Jun 17, 2024
@benbowler benbowler self-assigned this Jun 26, 2024
@benbowler
Copy link
Collaborator

I created an IB, should we consider dismissing the notification after the user clicks "Show Me"?

@benbowler benbowler removed their assignment Jun 27, 2024
@techanvil techanvil self-assigned this Jun 27, 2024
@techanvil
Copy link
Collaborator Author

Thanks @benbowler, yes, the intention is to dismiss the notification as well (i.e. maintain the current behaviour). I've updated the AC to make it clearer.

IB ✅

@techanvil techanvil removed their assignment Jun 27, 2024
@ankitrox ankitrox assigned ankitrox and unassigned ankitrox Sep 10, 2024
@nfmohit nfmohit self-assigned this Sep 16, 2024
@nfmohit nfmohit removed their assignment Sep 16, 2024
@benbowler benbowler assigned benbowler and unassigned benbowler Sep 16, 2024
@techanvil techanvil self-assigned this Sep 17, 2024
techanvil added a commit that referenced this issue Sep 17, 2024
@techanvil techanvil removed their assignment Sep 17, 2024
@wpdarren wpdarren assigned wpdarren and unassigned wpdarren Sep 17, 2024
@kelvinballoo
Copy link
Collaborator

QA Update ✅

Upon clicking the "Show me" CTA on the Setup Success Notice, the page scrolls to the Audiences Widget Area, and the notice is dismissed for the current user.

Moving ticket to Approval.

Desktop test:
8874.-.Test.success.mov

Mobile test:

RPReplay_Final1726600586.MP4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Module: Analytics Google Analytics module related issues P1 Medium priority Team M Issues for Squad 2 Type: Enhancement Improvement of an existing feature
Projects
None yet
Development

No branches or pull requests

8 participants