-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add callout button components #9063
Labels
Comments
techanvil
added
P1
Medium priority
Type: Enhancement
Improvement of an existing feature
labels
Jul 23, 2024
techanvil
changed the title
Add callout button components
Add callout button components.
Jul 23, 2024
This was referenced Jul 23, 2024
techanvil
changed the title
Add callout button components.
Add callout button components
Jul 23, 2024
IB ✔️ |
17 tasks
QA Update ✅
Callout button Callout Warning Callout Error Button Disabled callout Disabled Warning Callout Button Disabled Error Callout Button |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Feature Description
As mentioned on Figma, we have a new set of button designs that will be used for CTAs in callouts:
These will be used in callout notifications, for example:
Success notifications:
Warning notifications:
Error notifications:
The requirement for this issue is to create the buttons. Existing notifications will be updated to use the new components in a followup issue or issues.
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance criteria
button-1 callouts
Figma design should be available to use as a component. This should be as part of theButton
component with acallout
prop and another prop(s) to set the button style for each specified in Figma.Implementation Brief
assets/js/googlesitekit/components-gm2/Button.js
callout
- null by default, andcalloutStyle
- string enum, should accept one of the followingprimary|warning|error
(include it in thepropTypes
)site-kit-wp/assets/js/googlesitekit/components-gm2/Button.js
Line 99 in 3cce2fa
callout
prop is passed, it does not render this class. This will make it for easier usage, otherwise we would need to passtext
prop for everycallout
buttoncalloutStyle
prop, and one for thecallout
prop. So for thecallout
, you can usemdc-button--callout
and for the style,mdc-button--warning
, etc.mdc-button--callout
styles inassets/sass/vendor/_mdc-button.scss
and nest the 3 style variation classes under it to apply different color variations, specific to that class.mdc-button--tertiary
- but note vertical padding is slightly smaller on callout button then current one for tertiary button, and height is smaller by8px
on callout button, etc.Test Coverage
assets/js/googlesitekit/components-gm2/Button.stories.js
and into the VRT.QA Brief
Changelog entry
The text was updated successfully, but these errors were encountered: