Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Callout buttons #9110

Merged
merged 6 commits into from
Aug 1, 2024
Merged

Callout buttons #9110

merged 6 commits into from
Aug 1, 2024

Conversation

zutigrm
Copy link
Collaborator

@zutigrm zutigrm commented Aug 1, 2024

Summary

Addresses issue:

Relevant technical choices

PR Author Checklist

  • My code is tested and passes existing unit tests.
  • My code has an appropriate set of unit tests which all pass.
  • My code is backward-compatible with WordPress 5.2 and PHP 7.4.
  • My code follows the WordPress coding standards.
  • My code has proper inline documentation.
  • I have added a QA Brief on the issue linked above.
  • I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

  • Run the code.
  • Ensure the acceptance criteria are satisfied.
  • Reassess the implementation with the IB.
  • Ensure no unrelated changes are included.
  • Ensure CI checks pass.
  • Check Storybook where applicable.
  • Ensure there is a QA Brief.

Merge Reviewer Checklist

  • Ensure the PR has the correct target branch.
  • Double-check that the PR is okay to be merged.
  • Ensure the corresponding issue has a ZenHub release assigned.
  • Add a changelog message to the issue.

Copy link

github-actions bot commented Aug 1, 2024

Build files for 9922f3e have been deleted.

Copy link

github-actions bot commented Aug 1, 2024

Size Change: +2.86 kB (+0.17%)

Total Size: 1.69 MB

Filename Size Change
./dist/assets/css/googlesitekit-admin-css-********************.min.css 56.5 kB +761 B (+1.36%)
./dist/assets/css/googlesitekit-adminbar-css-********************.min.css 11.8 kB +757 B (+6.87%) 🔍
./dist/assets/css/googlesitekit-wp-dashboard-css-********************.min.css 8.2 kB +842 B (+11.44%) ⚠️
./dist/assets/js/googlesitekit-components-gm2-********************.js 5.96 kB +100 B (+1.71%)
./dist/assets/js/googlesitekit-main-dashboard-********************.js 147 kB +117 B (+0.08%)
./dist/assets/js/googlesitekit-modules-analytics-4-********************.js 165 kB +82 B (+0.05%)
./dist/assets/js/googlesitekit-settings-********************.js 74.4 kB +105 B (+0.14%)
./dist/assets/js/googlesitekit-widgets-********************.js 81.5 kB +99 B (+0.12%)
ℹ️ View Unchanged
Filename Size
./dist/assets/css/googlesitekit-authorize-application-css-********************.min.css 846 B
./dist/assets/js/31-********************.js 2.76 kB
./dist/assets/js/32-********************.js 2.25 kB
./dist/assets/js/33-********************.js 3.64 kB
./dist/assets/js/34-********************.js 935 B
./dist/assets/js/35-********************.js 892 B
./dist/assets/js/36-********************.js 3.12 kB
./dist/assets/js/analytics-advanced-tracking-********************.js 901 B
./dist/assets/js/googlesitekit-activation-********************.js 23.8 kB
./dist/assets/js/googlesitekit-ad-blocking-recovery-********************.js 59.8 kB
./dist/assets/js/googlesitekit-adminbar-********************.js 34.5 kB
./dist/assets/js/googlesitekit-api-********************.js 10 kB
./dist/assets/js/googlesitekit-components-gm3-********************.js 10.1 kB
./dist/assets/js/googlesitekit-consent-mode-********************.js 25.6 kB
./dist/assets/js/googlesitekit-data-********************.js 2.35 kB
./dist/assets/js/googlesitekit-datastore-forms-********************.js 9.03 kB
./dist/assets/js/googlesitekit-datastore-location-********************.js 2.08 kB
./dist/assets/js/googlesitekit-datastore-site-********************.js 20.4 kB
./dist/assets/js/googlesitekit-datastore-ui-********************.js 9.97 kB
./dist/assets/js/googlesitekit-datastore-user-********************.js 25.1 kB
./dist/assets/js/googlesitekit-entity-dashboard-********************.js 77.4 kB
./dist/assets/js/googlesitekit-events-provider-contact-form-7-********************.js 646 B
./dist/assets/js/googlesitekit-events-provider-easy-digital-downloads-********************.js 624 B
./dist/assets/js/googlesitekit-events-provider-mailchimp-********************.js 630 B
./dist/assets/js/googlesitekit-events-provider-ninja-forms-********************.js 712 B
./dist/assets/js/googlesitekit-events-provider-optin-monster-********************.js 675 B
./dist/assets/js/googlesitekit-events-provider-popup-maker-********************.js 634 B
./dist/assets/js/googlesitekit-events-provider-woocommerce-********************.js 657 B
./dist/assets/js/googlesitekit-events-provider-wpforms-********************.js 633 B
./dist/assets/js/googlesitekit-i18n-********************.js 3.93 kB
./dist/assets/js/googlesitekit-modules-ads-********************.js 29.5 kB
./dist/assets/js/googlesitekit-modules-adsense-********************.js 114 kB
./dist/assets/js/googlesitekit-modules-********************.js 22.1 kB
./dist/assets/js/googlesitekit-modules-pagespeed-insights-********************.js 22.5 kB
./dist/assets/js/googlesitekit-modules-reader-revenue-manager-********************.js 17.2 kB
./dist/assets/js/googlesitekit-modules-search-console-********************.js 59 kB
./dist/assets/js/googlesitekit-modules-tagmanager-********************.js 32 kB
./dist/assets/js/googlesitekit-notifications-********************.js 4.04 kB
./dist/assets/js/googlesitekit-polyfills-********************.js 376 B
./dist/assets/js/googlesitekit-splash-********************.js 74.2 kB
./dist/assets/js/googlesitekit-user-input-********************.js 48.9 kB
./dist/assets/js/googlesitekit-vendor-********************.js 321 kB
./dist/assets/js/googlesitekit-wp-dashboard-********************.js 61.8 kB
./dist/assets/js/runtime-********************.js 1.3 kB

compressed-size-action

@zutigrm
Copy link
Collaborator Author

zutigrm commented Aug 1, 2024

While adding additional stories, I noticed that we have unused hover button story, the button is not included in VRT, and class used for hover is not passed to the hoverSelector, instead we only apply it for icon variation using different class. I did quick investigation trying to update this to include hover style capture for all callouts button and default one, but it was behaving weirdly, couldn't lose too much time on this as it is out of scope so I opened a new issue #9111 for it

@eugene-manuilov eugene-manuilov merged commit b298e1f into develop Aug 1, 2024
20 of 21 checks passed
@eugene-manuilov eugene-manuilov deleted the enhancement/9063-callout-buttons branch August 1, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants