Period/full-stop is pushed onto a newline in survey footer

[tofumatt]

Bug Description

The survey footer has a bug, likely because of the link component used, that causes the period after the "Terms" link to appear on a new line.

Steps to reproduce

1. Trigger a user survey
2. Observe footer has a period on a newline.

Screenshots

---

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

• It should not be possible for the period after "Terms" in the footer to appear on a newline.

Implementation Brief

• Add a noFlex = false prop to the Link component, with a related new class:

'googlesitekit-cta-link--no-flex': !! noFlex,

• Add the noFlex to both Link components in assets/js/components/surveys/SurveyTerms.js
• Add CSS to this class that sets display: inline;

See proof-of-concept at #9075.

Test Coverage

• VRTs should continue to pass, except for the survey VRT which should need updating.

QA Brief

• Trigger a user survey or inspect the survey at https://google.github.io/site-kit-wp/storybook/develop/?path=/story/components-surveys-currentsurvey--survey-with-terms-story
• The survey footer should no longer have a stray period/fullstop ('.') on a newline after the "Terms" link.
• Other links in the plugin should not have any display issue.

Changelog entry

• Fix full-stop issue in the survey pop-up footer.

[eugene-manuilov]

IB ✔️

[mohitwp]

QA Update ✅

• Tested on dev environment.
• Verified the Storybook story
• Also, triggered the survey on site.
• Verified that the survey footer not have a stray period/fullstop ('.') on a newline after the "Terms" link.
• Also, verified other links on plugin. All looks good.