User Input - New Design - More Updates #6238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +108 B (0%) Total Size: 1.5 MB
ℹ️ View Unchanged
|
|
@nfmohit when creating follow-up PRs for the release, please remember to update the target branch as it always defaults to |
aaemnnosttv
requested changes
Dec 2, 2022
nfmohit
force-pushed
the
enhancement/#5890-design-followup
branch
from
8d1f96c
to
f2ea846
Compare
@aaemnnosttv My apologies, I missed it this time. I'll keep it in mind, thank you for correcting it and the heads-up!
I have rebased this branch and removed the unnecessary changes, leaving only the necessary change. Does it look good now? Thanks! |
aaemnnosttv
reviewed
Dec 2, 2022
There was a problem hiding this comment.
Thanks for rebasing @nfmohit that's perfectly fine with me.
Let's keep this PR focused on the change to the progress bar and we can revisit a11y as a primary focus in a new issue.
Comment on lines
80
to
84
| } else { | ||
| const el = optionsRef.current.querySelector( | ||
| `input[type="${ optionType }"]` | ||
| ); | ||
| focusOption( el ); |
There was a problem hiding this comment.
Let's not change this here. It's out of scope for the issue and I'm not sure if we should. Accessibility should probably be reviewed separately once the design iterations are implemented (or nearly done).
There was a problem hiding this comment.
Understood, reverted this change. Thank you for confirming, @aaemnnosttv!
This reverts commit f88344a.
aaemnnosttv
approved these changes
Dec 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses issue:
Relevant technical choices
This PR addresses this comment and does the following changes:
PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist