Fix Site Health notices and add basic E2E tests #6598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
techanvil
requested changes
Feb 20, 2023
There was a problem hiding this comment.
This looks good @aaemnnosttv and works well. I have left a few comments on the tests, please take a look.
|
|
||
| describe( 'Site Health', () => { | ||
| it( 'adds debug data to the info tab when Site Kit is active but not setup', async () => { | ||
| await setupSiteKit(); |
There was a problem hiding this comment.
The body of this test is the same as the one below - I'm guessing this call to setupSiteKit() needs to be changed/removed.
| array( | ||
| $module_slug => array( | ||
| 'sharedRoles' => array( 'editor' ), | ||
| 'management' => 'owner', |
There was a problem hiding this comment.
It might be worth changing the value here to all_admins to further distinguish this from the defaults...
Suggested change
| 'management' => 'owner', | |
| 'management' => 'all_admins', |
There was a problem hiding this comment.
I thought about that before and decided to go this way but I don't see a reason not to; SGTM 👍
| @@ -55,7 +55,6 @@ public function test_register() { | |||
| 'verification_status', | |||
| 'connected_user_count', | |||
| 'active_modules', | |||
| 'recoverable_modules', | |||
There was a problem hiding this comment.
It could be worth adding an additional test case here to cover the Dashboard Sharing fields...
techanvil
approved these changes
Feb 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses issue:
Relevant technical choices
PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist