Follow-up: Wait until survey trigger is complete #7222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -6 B (0%) Total Size: 1.38 MB
ℹ️ View Unchanged
|
|
Build files for 89b5d1d have been deleted. |
aaemnnosttv
force-pushed
the
enhancement/#6180-user-input-survey-followup
branch
from
783862e
to
118ff33
Compare
aaemnnosttv
reviewed
Jun 29, 2023
| .dispatch( CORE_USER ) | ||
| .triggerSurvey( triggerID ); | ||
| const { response, error } = yield Data.commonActions.await( | ||
| yield dispatch( CORE_USER ).triggerSurvey( triggerID ) |
There was a problem hiding this comment.
This yield is unneccessary – dispatch returns a promise. yield is for "raw" actions.
There was a problem hiding this comment.
Ah, my mistake for overlooking, thank you for correcting!
aaemnnosttv
approved these changes
Jun 29, 2023
Ah, thank you so much for the corrections here, I've duly noted the mistakes and improvements for future reference, thank you @aaemnnosttv! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses issue:
Relevant technical choices
This follow-up PR aims to resolve this issue reported by the QA team, where User Input completion navigates the user to the Site Kit dashboard, but doesn't wait for the survey trigger to complete. Thus, the survey trigger request is often cancelled.
PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist