Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix VRTs for UA Cutoff Warning. #7249

Merged
merged 1 commit into from
Jul 5, 2023

Conversation

jimmymadon
Copy link
Collaborator

@jimmymadon jimmymadon commented Jul 3, 2023

Summary

Addresses issue:

Relevant technical choices

PR Author Checklist

  • My code is tested and passes existing unit tests.
  • My code has an appropriate set of unit tests which all pass.
  • My code is backward-compatible with WordPress 5.2 and PHP 5.6.
  • My code follows the WordPress coding standards.
  • My code has proper inline documentation.
  • I have added a QA Brief on the issue linked above.
  • I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

  • Run the code.
  • Ensure the acceptance criteria are satisfied.
  • Reassess the implementation with the IB.
  • Ensure no unrelated changes are included.
  • Ensure CI checks pass.
  • Check Storybook where applicable.
  • Ensure there is a QA Brief.

Merge Reviewer Checklist

  • Ensure the PR has the correct target branch.
  • Double-check that the PR is okay to be merged.
  • Ensure the corresponding issue has a ZenHub release assigned.
  • Add a changelog message to the issue.

@github-actions
Copy link

github-actions bot commented Jul 3, 2023

Build files for c5d6001 have been deleted.

@github-actions
Copy link

github-actions bot commented Jul 3, 2023

Size Change: 0 B

Total Size: 1.38 MB

ℹ️ View Unchanged
Filename Size
./dist/assets/css/googlesitekit-admin-css-********************.min.css 50 kB
./dist/assets/css/googlesitekit-adminbar-css-********************.min.css 11.2 kB
./dist/assets/css/googlesitekit-wp-dashboard-css-********************.min.css 7.55 kB
./dist/assets/js/30-********************.js 2.8 kB
./dist/assets/js/31-********************.js 2.28 kB
./dist/assets/js/32-********************.js 3.72 kB
./dist/assets/js/33-********************.js 3.12 kB
./dist/assets/js/analytics-advanced-tracking-********************.js 769 B
./dist/assets/js/googlesitekit-activation-********************.js 24.1 kB
./dist/assets/js/googlesitekit-ad-blocking-recovery-********************.js 52.1 kB
./dist/assets/js/googlesitekit-adminbar-********************.js 33.1 kB
./dist/assets/js/googlesitekit-api-********************.js 9.87 kB
./dist/assets/js/googlesitekit-components-gm2-********************.js 5.29 kB
./dist/assets/js/googlesitekit-components-gm3-********************.js 9.95 kB
./dist/assets/js/googlesitekit-data-********************.js 2.18 kB
./dist/assets/js/googlesitekit-datastore-forms-********************.js 9.29 kB
./dist/assets/js/googlesitekit-datastore-location-********************.js 2.09 kB
./dist/assets/js/googlesitekit-datastore-site-********************.js 16.5 kB
./dist/assets/js/googlesitekit-datastore-ui-********************.js 9.39 kB
./dist/assets/js/googlesitekit-datastore-user-********************.js 23.3 kB
./dist/assets/js/googlesitekit-entity-dashboard-********************.js 66.3 kB
./dist/assets/js/googlesitekit-i18n-********************.js 3.92 kB
./dist/assets/js/googlesitekit-main-dashboard-********************.js 80.4 kB
./dist/assets/js/googlesitekit-modules-adsense-********************.js 106 kB
./dist/assets/js/googlesitekit-modules-analytics-4-********************.js 56 kB
./dist/assets/js/googlesitekit-modules-analytics-********************.js 88.1 kB
./dist/assets/js/googlesitekit-modules-********************.js 21.6 kB
./dist/assets/js/googlesitekit-modules-optimize-********************.js 20.6 kB
./dist/assets/js/googlesitekit-modules-pagespeed-insights-********************.js 21.4 kB
./dist/assets/js/googlesitekit-modules-search-console-********************.js 52.3 kB
./dist/assets/js/googlesitekit-modules-tagmanager-********************.js 32.4 kB
./dist/assets/js/googlesitekit-polyfills-********************.js 379 B
./dist/assets/js/googlesitekit-settings-********************.js 49.1 kB
./dist/assets/js/googlesitekit-splash-********************.js 66.6 kB
./dist/assets/js/googlesitekit-user-input-********************.js 42 kB
./dist/assets/js/googlesitekit-vendor-********************.js 311 kB
./dist/assets/js/googlesitekit-widgets-********************.js 18 kB
./dist/assets/js/googlesitekit-wp-dashboard-********************.js 62.9 kB
./dist/assets/js/runtime-********************.js 1.26 kB

compressed-size-action

Copy link
Collaborator

@aaemnnosttv aaemnnosttv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks @jimmymadon !

@aaemnnosttv aaemnnosttv merged commit 09529c7 into develop Jul 5, 2023
15 of 16 checks passed
@aaemnnosttv aaemnnosttv deleted the infrastructure/7248-update-UA-cutoff-VRTs branch July 5, 2023 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants