Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove possible null from stripos. #7489

Merged
merged 1 commit into from
Aug 23, 2023
Merged

Remove possible null from stripos. #7489

merged 1 commit into from
Aug 23, 2023

Conversation

tofumatt
Copy link
Collaborator

@tofumatt tofumatt commented Aug 23, 2023

Summary

Addresses issue:

Relevant technical choices

I didn't quite catch in the original IB when reviewing this that $this->context->input()->filter( INPUT_GET, 'rest_route' ) might be null, which is what I'm thinking caused this issue: #7147 (comment)

The IB mentioned to make sure we didn't pass null, but I interpretted that literally and then merged the PR, as in testing it worked fine for me—I couldn't get the error described in the issue to appear.

Anyhow, this should fix it.

Note for merge reviewers: this was already in the release so targets main. After merging, make sure to merge main back into develop so this fix is in develop 🙂

PR Author Checklist

  • My code is tested and passes existing unit tests.
  • My code has an appropriate set of unit tests which all pass.
  • My code is backward-compatible with WordPress 5.2 and PHP 5.6.
  • My code follows the WordPress coding standards.
  • My code has proper inline documentation.
  • I have added a QA Brief on the issue linked above.
  • I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

  • Run the code.
  • Ensure the acceptance criteria are satisfied.
  • Reassess the implementation with the IB.
  • Ensure no unrelated changes are included.
  • Ensure CI checks pass.
  • Check Storybook where applicable.
  • Ensure there is a QA Brief.

Merge Reviewer Checklist

  • Ensure the PR has the correct target branch.
  • Double-check that the PR is okay to be merged.
  • Ensure the corresponding issue has a ZenHub release assigned.
  • Add a changelog message to the issue.

@github-actions
Copy link

github-actions bot commented Aug 23, 2023

Build files for 816a3d4 have been deleted.

Copy link
Collaborator

@techanvil techanvil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@techanvil techanvil merged commit 70bd97d into main Aug 23, 2023
16 of 17 checks passed
@techanvil techanvil deleted the fix-possible-null-7147 branch August 23, 2023 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants