Remove possible null
from stripos
.
#7489
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses issue:
strpos(): Passing null to parameter #1 ($haystack) of type string is deprecated
#7147Relevant technical choices
I didn't quite catch in the original IB when reviewing this that
$this->context->input()->filter( INPUT_GET, 'rest_route' )
might benull
, which is what I'm thinking caused this issue: #7147 (comment)The IB mentioned to make sure we didn't pass
null
, but I interpretted that literally and then merged the PR, as in testing it worked fine for me—I couldn't get the error described in the issue to appear.Anyhow, this should fix it.
Note for merge reviewers: this was already in the release so targets
main
. After merging, make sure to mergemain
back intodevelop
so this fix is indevelop
🙂PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist