Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Key Metrics toggle in SK Settings when answer based matrices are used #7503

Merged
merged 6 commits into from
Aug 29, 2023
Merged

Fix Key Metrics toggle in SK Settings when answer based matrices are used #7503

merged 6 commits into from
Aug 29, 2023

Commits on Aug 25, 2023

  1. Make widgetSlugs optional.

    @kuasha420
    kuasha420 committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    da37ceb View commit details
    Browse the repository at this point in the history

  2. Only set keyMetricsSetupCompleted to true if there is widgetSlugs.

    @kuasha420
    kuasha420 committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    5da551f View commit details
    Browse the repository at this point in the history

  3. Update handleKeyMetricsToggle to not pass widgetSlugs in request … 

    …body.
    @kuasha420
    kuasha420 committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    4d9a4b9 View commit details
    Browse the repository at this point in the history

  4. Update the action for non empty argument.

    @kuasha420
    kuasha420 committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    7fcc11c View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2023

  1. Add JS test coverage.

    @kuasha420
    kuasha420 committed Aug 27, 2023
    Configuration menu
    Copy the full SHA
    7c421a4 View commit details
    Browse the repository at this point in the history

  2. Add PHP test coverage.

    @kuasha420
    kuasha420 committed Aug 27, 2023
    Configuration menu
    Copy the full SHA
    836fe8d View commit details
    Browse the repository at this point in the history