KMW / 7577 Visits Per Visitor KMW Tile

[10upsimon]

Summary

Addresses issue:

• Create "Visits per visitor" key metric widget tile #7577

Relevant technical choices

• Defined new VisitsPerVisitorWidget component and subsequent constants and identifiers such as KM_ANALYTICS_VISITS_PER_VISITOR .
• Registered widget in GA4 module index, behind newsKeyMetrics feature flag.
• Added VisitsPerVisitorWidget to list of key metrics widgets for side panel display.
• Ensured that the sessionsPerUser metric is added to allowable shared metrics for shared dashboard scenarios.
• Added applicable VRT tests.
  • Subsequently added sessionsPerUser to ANALYTICS_4_METRIC_TYPES const in order for correct mock data to be surfaced within story scenarios.
• Added applicable JS unit tests.

PR Author Checklist

• My code is tested and passes existing unit tests.
• My code has an appropriate set of unit tests which all pass.
• My code is backward-compatible with WordPress 5.2 and PHP 5.6.
• My code follows the WordPress coding standards.
• My code has proper inline documentation.
• I have added a QA Brief on the issue linked above.
• I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

---

Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

• Run the code.
• Ensure the acceptance criteria are satisfied.
• Reassess the implementation with the IB.
• Ensure no unrelated changes are included.
• Ensure CI checks pass.
• Check Storybook where applicable.
• Ensure there is a QA Brief.

Merge Reviewer Checklist

• Ensure the PR has the correct target branch.
• Double-check that the PR is okay to be merged.
• Ensure the corresponding issue has a ZenHub release assigned.
• Add a changelog message to the issue.

[10upsimon]

Note to reviewer, there is a known issue with failing PHP 7.4 WP Nightly build PHP tests. See Slack thread here.

[github-actions]

Build files for 81ab140 have been deleted.

[github-actions]

Size Change: +866 B (0%)

Total Size: 1.41 MB

Filename	Size	Change
./dist/assets/css/googlesitekit-admin-css-********************.min.css	51.5 kB	+13 B (0%)
./dist/assets/js/googlesitekit-activation-********************.js	22.2 kB	+20 B (0%)
./dist/assets/js/googlesitekit-ad-blocking-recovery-********************.js	53.4 kB	+18 B (0%)
./dist/assets/js/googlesitekit-adminbar-********************.js	32.4 kB	+14 B (0%)
./dist/assets/js/googlesitekit-api-********************.js	9.63 kB	+13 B (0%)
./dist/assets/js/googlesitekit-components-gm2-********************.js	5.61 kB	+1 B (0%)
./dist/assets/js/googlesitekit-components-gm3-********************.js	9.98 kB	+2 B (0%)
./dist/assets/js/googlesitekit-data-********************.js	2.18 kB	-1 B (0%)
./dist/assets/js/googlesitekit-datastore-location-********************.js	2.09 kB	+2 B (0%)
./dist/assets/js/googlesitekit-datastore-site-********************.js	17.8 kB	+19 B (0%)
./dist/assets/js/googlesitekit-datastore-ui-********************.js	9.1 kB	-1 B (0%)
./dist/assets/js/googlesitekit-datastore-user-********************.js	23.2 kB	-16 B (0%)
./dist/assets/js/googlesitekit-entity-dashboard-********************.js	65.2 kB	+11 B (0%)
./dist/assets/js/googlesitekit-main-dashboard-********************.js	81.1 kB	+272 B (0%)
./dist/assets/js/googlesitekit-modules-adsense-********************.js	106 kB	-1 B (0%)
./dist/assets/js/googlesitekit-modules-analytics-4-********************.js	68.8 kB	+324 B (0%)
./dist/assets/js/googlesitekit-modules-analytics-********************.js	86.1 kB	+40 B (0%)
./dist/assets/js/googlesitekit-modules-********************.js	21.1 kB	+20 B (0%)
./dist/assets/js/googlesitekit-modules-optimize-********************.js	19 kB	+19 B (0%)
./dist/assets/js/googlesitekit-modules-pagespeed-insights-********************.js	20.5 kB	+5 B (0%)
./dist/assets/js/googlesitekit-modules-search-console-********************.js	60.7 kB	+20 B (0%)
./dist/assets/js/googlesitekit-modules-tagmanager-********************.js	30.9 kB	+16 B (0%)
./dist/assets/js/googlesitekit-settings-********************.js	47.5 kB	+11 B (0%)
./dist/assets/js/googlesitekit-splash-********************.js	65.5 kB	+15 B (0%)
./dist/assets/js/googlesitekit-user-input-********************.js	40.2 kB	+19 B (0%)
./dist/assets/js/googlesitekit-vendor-********************.js	317 kB	-8 B (0%)
./dist/assets/js/googlesitekit-widgets-********************.js	28.6 kB	+11 B (0%)
./dist/assets/js/googlesitekit-wp-dashboard-********************.js	61.8 kB	+11 B (0%)
./dist/assets/js/runtime-********************.js	1.3 kB	-3 B (0%)

ℹ️ View Unchanged

Filename	Size
./dist/assets/css/googlesitekit-adminbar-css-********************.min.css	11.4 kB
./dist/assets/css/googlesitekit-wp-dashboard-css-********************.min.css	7.58 kB
./dist/assets/js/30-********************.js	2.8 kB
./dist/assets/js/31-********************.js	2.28 kB
./dist/assets/js/32-********************.js	3.72 kB
./dist/assets/js/33-********************.js	930 B
./dist/assets/js/34-********************.js	888 B
./dist/assets/js/35-********************.js	3.12 kB
./dist/assets/js/analytics-advanced-tracking-********************.js	769 B
./dist/assets/js/googlesitekit-datastore-forms-********************.js	9 kB
./dist/assets/js/googlesitekit-i18n-********************.js	3.92 kB
./dist/assets/js/googlesitekit-polyfills-********************.js	379 B

_{compressed-size-action}

[10upsimon]

Update on tests, 3 failures with known issues at present:

1. E2E (WordPress Latest) - 1 failure, failing at User Input Settings which sounds like it's a known issue.
2. E2E (WordPress Nightly) - 8 failures, failing at User Input Settings and deprecation notices.
3. PHP Tests (PHP 7.4, WordPress Nightly) - Failing at deprecation notices.

[tofumatt]

Looks good to me 👍🏻

[tofumatt]

Odd, I'm not seeing this widget appear in the list of Key Metrics tiles to select:

Any reason why this would be? It seems to work fine 🤔

EDIT: Forgot to enable newsKeyMetrics 😅 All good now! 🙂