Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom dimension tile wrapper #7680

Merged
merged 50 commits into from
Oct 17, 2023
Merged

Custom dimension tile wrapper #7680

merged 50 commits into from
Oct 17, 2023

Commits on Oct 9, 2023

  1. Add necessary datastore selectors.

    @nfmohit
    nfmohit committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    6d229ff View commit details
    Browse the repository at this point in the history

  2. Extend CTA to allow a new headerContent prop.

    @nfmohit
    nfmohit committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    f7ac9f6 View commit details
    Browse the repository at this point in the history

  3. Create new InfoTooltip component.

    @nfmohit
    nfmohit committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    1c65e51 View commit details
    Browse the repository at this point in the history

  4. Update MetricTileError.

    @nfmohit
    nfmohit committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    5a48840 View commit details
    Browse the repository at this point in the history

  5. Use MetricTileWrapper.

    @nfmohit
    nfmohit committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    a6268e2 View commit details
    Browse the repository at this point in the history

  6. Update snapshot.

    @nfmohit
    nfmohit committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    46d8300 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2023

  1. Update syncAvailableCustomDimensions action.

    @nfmohit
    nfmohit committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    806db7a View commit details
    Browse the repository at this point in the history

  2. Error handling for unavailable custom dimension.

    @nfmohit
    nfmohit committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    f1014ea View commit details
    Browse the repository at this point in the history

  3. Update MetricTileError location.

    @nfmohit
    nfmohit committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    cb6abfd View commit details
    Browse the repository at this point in the history

  4. Do not show custom dimension errors when loading.

    @nfmohit
    nfmohit committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    825d026 View commit details
    Browse the repository at this point in the history

  5. Fix typo.

    @nfmohit
    nfmohit committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    343b6c4 View commit details
    Browse the repository at this point in the history

  6. Add tile skeletons.

    @nfmohit
    nfmohit committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    87ffac6 View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2023

  1. Add receiveCustomDimensionCreationError action.

    @nfmohit
    nfmohit committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    c4be532 View commit details
    Browse the repository at this point in the history

  2. Fix styling issues.

    @nfmohit
    nfmohit committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    7e16c94 View commit details
    Browse the repository at this point in the history

  3. Add Storybook stories.

    @nfmohit
    nfmohit committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    62a3750 View commit details
    Browse the repository at this point in the history

  4. Make stories concise.

    @nfmohit
    nfmohit committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    b1805aa View commit details
    Browse the repository at this point in the history

  5. Rename action & selector.

    @nfmohit
    nfmohit committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    88c49aa View commit details
    Browse the repository at this point in the history

  6. Update datastore test cases.

    @nfmohit
    nfmohit committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    b722d80 View commit details
    Browse the repository at this point in the history

  7. Update Storybook story.

    @nfmohit
    nfmohit committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    b3dfa19 View commit details
    Browse the repository at this point in the history

  8. Add test cases for MetricTileWrapper.

    @nfmohit
    nfmohit committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    f1fb97c View commit details
    Browse the repository at this point in the history

  9. Track custom dimensions creation state.

    @nfmohit
    nfmohit committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    6bbbb70 View commit details
    Browse the repository at this point in the history

  10. Update custom dimension creation initiation.

    @nfmohit
    nfmohit committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    42fc1f4 View commit details
    Browse the repository at this point in the history

  11. Merge branch 'develop' into enhancement/#7601-custom-dimension-wrapper.

    @nfmohit
    nfmohit committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    10e4262 View commit details
    Browse the repository at this point in the history

  12. Update VRT references.

    @nfmohit
    nfmohit committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    b5a6237 View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2023

  1. Create CustomDimensionsWrapper.

    @nfmohit
    nfmohit committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    01a8307 View commit details
    Browse the repository at this point in the history

  2. Update translation strings.

    @nfmohit
    nfmohit committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    157bd14 View commit details
    Browse the repository at this point in the history

  3. Fix failing tests.

    @nfmohit
    nfmohit committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    3d19e6f View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2023

  1. Merge branch 'develop' into enhancement/#7601-custom-dimension-wrapper.

    @nfmohit
    nfmohit committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    392943b View commit details
    Browse the repository at this point in the history

  2. Render InfoTooltip unconditionally in MetricTileHeader.

    @nfmohit
    nfmohit committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    c9808ef View commit details
    Browse the repository at this point in the history

  3. Replace MetricTileLoading with MetricTileWrapper.

    @nfmohit
    nfmohit committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    faa8659 View commit details
    Browse the repository at this point in the history

  4. Update datapoint to work without parameter.

    @nfmohit
    nfmohit committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    ee220a5 View commit details
    Browse the repository at this point in the history

  5. Create HOC for custom dimensions.

    @nfmohit
    nfmohit committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    1bd7c19 View commit details
    Browse the repository at this point in the history

  6. Address CR feedback.

    @nfmohit
    nfmohit committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    4d9338d View commit details
    Browse the repository at this point in the history

  7. Fix failing test.

    @nfmohit
    nfmohit committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    481dfa1 View commit details
    Browse the repository at this point in the history

  8. Update VRT references.

    @nfmohit
    nfmohit committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    8b667c7 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2023

  1. Render InfoTooltip unconditionally in MetricTileError.

    @nfmohit
    nfmohit committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    c7f843b View commit details
    Browse the repository at this point in the history

  2. Correctly order props.

    @nfmohit
    nfmohit committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    0346a2c View commit details
    Browse the repository at this point in the history

  3. Remove feature flag check from withCustomDimensions.

    @nfmohit
    nfmohit committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    fc8ee31 View commit details
    Browse the repository at this point in the history

  4. Use state for assertion instead of selector.

    @nfmohit
    nfmohit committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    3788886 View commit details
    Browse the repository at this point in the history

  5. Create test registry in beforeEach.

    @nfmohit
    nfmohit committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    e5a5851 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'develop' into enhancement/#7601-custom-dimension-wrapper.

    @nfmohit
    nfmohit committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    818329e View commit details
    Browse the repository at this point in the history

  7. Fix failing tests.

    @nfmohit
    nfmohit committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    ae363c9 View commit details
    Browse the repository at this point in the history

  8. Render InfoTooltip in MetricTileError conditionally.

    @nfmohit
    nfmohit committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    eff625a View commit details
    Browse the repository at this point in the history

  9. Remove unnecessary VRT scenarios.

    @nfmohit
    nfmohit committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    0eabcf5 View commit details
    Browse the repository at this point in the history

  10. Replace receiveCreateCustomDimensionError action with `provideCusto… 

    …mDimensionError` test utility.
    @nfmohit
    nfmohit committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    1e5f159 View commit details
    Browse the repository at this point in the history

  11. Remove syncAvailableCustomDimensions.

    @nfmohit
    nfmohit committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    443a91d View commit details
    Browse the repository at this point in the history

  12. Address CR feedback.

    @nfmohit
    nfmohit committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    20be742 View commit details
    Browse the repository at this point in the history

  13. Move test-utils.js file to the utils folder and rename it to be custo… 

    …m-dimensions.js.
    @eugene-manuilov
    eugene-manuilov committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    498c466 View commit details
    Browse the repository at this point in the history

  14. Update report options to allow passing a function.

    @eugene-manuilov
    eugene-manuilov committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    b2cfa63 View commit details
    Browse the repository at this point in the history

  15. Fix broken imports.

    @eugene-manuilov
    eugene-manuilov committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    6553776 View commit details
    Browse the repository at this point in the history