Create infrastructure for detecting & installing WP Consent API. #8305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build files for 8277b0f have been deleted. |
|
Size Change: +81 B (0%) Total Size: 1.49 MB
ℹ️ View Unchanged
|
techanvil
commented
Feb 22, 2024
| $install_url = $nonce_url( self_admin_url( 'update.php?action=install-plugin&plugin=' . $slug ), 'install-plugin_' . $slug ); | ||
|
|
||
| $response['wpConsentPlugin'] = array( | ||
| 'installed' => $installed, |
There was a problem hiding this comment.
Note that there's no need to include the active field specified in the AC. This is because hasConsentAPI indicates the active status.
aaemnnosttv
approved these changes
Feb 22, 2024
There was a problem hiding this comment.
Thanks @techanvil – this LGTM, I just had one thought about some of the plugin checks but it's not blocking and we can always address that in a follow-up.
Comment on lines
+143
to
+144
| $slug = 'wp-consent-api'; | ||
| $plugin = "$slug/$slug.php"; |
There was a problem hiding this comment.
This could actually be different if it were installed via Composer. See https://packagist.org/packages/rlankhorst/wp-consent-level-api
Definitely an edge case for most of our users I think, but worth keeping in mind that the $plugin can't always be assumed to be $slug/$slug. Not just because of Composer, but the directory can be renamed, or sometimes even the plugin itself can change the name of its entry point php file.
There was a problem hiding this comment.
Thanks @aaemnnosttv, that's a good point. I've created #8307 to address this later. Seems like a post-MVP issue to me.
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses issue:
PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist