Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ads module e2e tests #8430

Merged
merged 21 commits into from
Apr 10, 2024
Merged

Ads module e2e tests #8430

merged 21 commits into from
Apr 10, 2024

Conversation

zutigrm
Copy link
Collaborator

@zutigrm zutigrm commented Mar 27, 2024

Summary

Addresses issue:

Relevant technical choices

Note some behaviour changed since this AC was originally written, mostly around how input field shows validation, so E2E implemented here tests the current behaviour of input field validation.

Test case for showing the incomplete module on empty value saved is included in one test case, it didn't seem necessary to duplicate it

PR Author Checklist

  • My code is tested and passes existing unit tests.
  • My code has an appropriate set of unit tests which all pass.
  • My code is backward-compatible with WordPress 5.2 and PHP 5.6.
  • My code follows the WordPress coding standards.
  • My code has proper inline documentation.
  • I have added a QA Brief on the issue linked above.
  • I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

  • Run the code.
  • Ensure the acceptance criteria are satisfied.
  • Reassess the implementation with the IB.
  • Ensure no unrelated changes are included.
  • Ensure CI checks pass.
  • Check Storybook where applicable.
  • Ensure there is a QA Brief.

Merge Reviewer Checklist

  • Ensure the PR has the correct target branch.
  • Double-check that the PR is okay to be merged.
  • Ensure the corresponding issue has a ZenHub release assigned.
  • Add a changelog message to the issue.

@zutigrm zutigrm changed the title Enhancement/8314 ads module e2e tests Ads module e2e tests Apr 2, 2024
@zutigrm zutigrm marked this pull request as ready for review April 2, 2024 11:35
Copy link
Collaborator

@tofumatt tofumatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just some spec test naming tweaks and such but I'll commit them then get this merged 👍🏻

@tofumatt tofumatt merged commit b2a837f into develop Apr 10, 2024
9 checks passed
@tofumatt tofumatt deleted the enhancement/8314-ads-module-e2e-tests branch April 10, 2024 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants