-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ads module e2e tests #8430
Merged
Merged
Ads module e2e tests #8430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ds-module-e2e-tests.
tofumatt
reviewed
Apr 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just some spec test naming tweaks and such but I'll commit them then get this merged 👍🏻
tests/e2e/specs/modules/ads/setup-no-previous-ads-cenversion-id.test.js
Outdated
Show resolved
Hide resolved
tests/e2e/specs/modules/ads/setup-no-previous-ads-cenversion-id.test.js
Outdated
Show resolved
Hide resolved
tests/e2e/specs/modules/ads/setup-no-previous-ads-cenversion-id.test.js
Outdated
Show resolved
Hide resolved
tests/e2e/specs/modules/ads/setup-with-previous-ads-cenversion-id.test.js
Outdated
Show resolved
Hide resolved
tests/e2e/specs/modules/ads/setup-with-previous-ads-cenversion-id.test.js
Outdated
Show resolved
Hide resolved
tests/e2e/specs/modules/ads/setup-with-previous-ads-cenversion-id.test.js
Outdated
Show resolved
Hide resolved
tests/e2e/specs/modules/ads/setup-with-previous-ads-cenversion-id.test.js
Outdated
Show resolved
Hide resolved
tests/e2e/specs/modules/ads/setup-with-previous-ads-cenversion-id.test.js
Show resolved
Hide resolved
tofumatt
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses issue:
Ads
Module E2E Tests to Cover Basic Module Setup Flow #8314Relevant technical choices
Note some behaviour changed since this AC was originally written, mostly around how input field shows validation, so E2E implemented here tests the current behaviour of input field validation.
Test case for showing the incomplete module on empty value saved is included in one test case, it didn't seem necessary to duplicate it
PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist