Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8136 Follow Up #8625

Merged
merged 5 commits into from
Apr 26, 2024
Merged

8136 Follow Up #8625

merged 5 commits into from
Apr 26, 2024

Conversation

kuasha420
Copy link
Contributor

Summary

Addresses issue:

Relevant technical choices

PR Author Checklist

  • My code is tested and passes existing unit tests.
  • My code has an appropriate set of unit tests which all pass.
  • My code is backward-compatible with WordPress 5.2 and PHP 7.4.
  • My code follows the WordPress coding standards.
  • My code has proper inline documentation.
  • I have added a QA Brief on the issue linked above.
  • I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

  • Run the code.
  • Ensure the acceptance criteria are satisfied.
  • Reassess the implementation with the IB.
  • Ensure no unrelated changes are included.
  • Ensure CI checks pass.
  • Check Storybook where applicable.
  • Ensure there is a QA Brief.

Merge Reviewer Checklist

  • Ensure the PR has the correct target branch.
  • Double-check that the PR is okay to be merged.
  • Ensure the corresponding issue has a ZenHub release assigned.
  • Add a changelog message to the issue.

@kuasha420 kuasha420 marked this pull request as ready for review April 26, 2024 08:57
Copy link

github-actions bot commented Apr 26, 2024

Build files for effb222 have been deleted.

@@ -103,7 +103,7 @@
gap: $grid-gap-desktop;
grid-auto-columns: minmax(400px, 1fr);
grid-auto-flow: column;
grid-template-columns: repeat(auto-fill, minmax(400px, 1fr));
grid-template-columns: repeat(auto-fit, minmax(400px, 1fr));
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @kuasha420, I noticed that the two-audience view was being laid out with an extra, unwanted grid column at wide viewports:

image

Changing the repeat value to auto-fit fixes this in my testing; I've applied the change myself to save the round trip.

Copy link

Size Change: +534 B (0%)

Total Size: 1.43 MB

Filename Size Change
./dist/assets/css/googlesitekit-admin-css-********************.min.css 53.7 kB +28 B (0%)
./dist/assets/css/googlesitekit-authorize-application-css-********************.min.css 603 B +507 B (+528%) 🆘
./dist/assets/js/googlesitekit-modules-analytics-4-********************.js 109 kB -1 B (0%)
ℹ️ View Unchanged
Filename Size
./dist/assets/css/googlesitekit-adminbar-css-********************.min.css 11.2 kB
./dist/assets/css/googlesitekit-wp-dashboard-css-********************.min.css 7.48 kB
./dist/assets/js/29-********************.js 2.8 kB
./dist/assets/js/30-********************.js 2.28 kB
./dist/assets/js/31-********************.js 3.72 kB
./dist/assets/js/32-********************.js 929 B
./dist/assets/js/33-********************.js 888 B
./dist/assets/js/34-********************.js 3.12 kB
./dist/assets/js/analytics-advanced-tracking-********************.js 778 B
./dist/assets/js/googlesitekit-activation-********************.js 23.8 kB
./dist/assets/js/googlesitekit-ad-blocking-recovery-********************.js 57.4 kB
./dist/assets/js/googlesitekit-adminbar-********************.js 34.2 kB
./dist/assets/js/googlesitekit-api-********************.js 10.1 kB
./dist/assets/js/googlesitekit-components-gm2-********************.js 5.88 kB
./dist/assets/js/googlesitekit-components-gm3-********************.js 10 kB
./dist/assets/js/googlesitekit-data-********************.js 2.18 kB
./dist/assets/js/googlesitekit-datastore-forms-********************.js 9.1 kB
./dist/assets/js/googlesitekit-datastore-location-********************.js 2.09 kB
./dist/assets/js/googlesitekit-datastore-site-********************.js 19.1 kB
./dist/assets/js/googlesitekit-datastore-ui-********************.js 10.1 kB
./dist/assets/js/googlesitekit-datastore-user-********************.js 24.8 kB
./dist/assets/js/googlesitekit-entity-dashboard-********************.js 71.2 kB
./dist/assets/js/googlesitekit-i18n-********************.js 3.92 kB
./dist/assets/js/googlesitekit-main-dashboard-********************.js 95.7 kB
./dist/assets/js/googlesitekit-modules-********************.js 21.7 kB
./dist/assets/js/googlesitekit-modules-ads-********************.js 19.6 kB
./dist/assets/js/googlesitekit-modules-adsense-********************.js 111 kB
./dist/assets/js/googlesitekit-modules-pagespeed-insights-********************.js 22.4 kB
./dist/assets/js/googlesitekit-modules-search-console-********************.js 58 kB
./dist/assets/js/googlesitekit-modules-tagmanager-********************.js 30 kB
./dist/assets/js/googlesitekit-polyfills-********************.js 379 B
./dist/assets/js/googlesitekit-settings-********************.js 59.7 kB
./dist/assets/js/googlesitekit-splash-********************.js 71.7 kB
./dist/assets/js/googlesitekit-user-input-********************.js 46.9 kB
./dist/assets/js/googlesitekit-vendor-********************.js 316 kB
./dist/assets/js/googlesitekit-widgets-********************.js 33.4 kB
./dist/assets/js/googlesitekit-wp-dashboard-********************.js 60.2 kB
./dist/assets/js/runtime-********************.js 1.29 kB

compressed-size-action

Copy link
Collaborator

@techanvil techanvil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice one @kuasha420!

@techanvil techanvil merged commit b2aab85 into develop Apr 26, 2024
22 checks passed
@techanvil techanvil deleted the fix/8136-follow-up branch April 26, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants