-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8136 Follow Up #8625
8136 Follow Up #8625
Conversation
Build files for effb222 have been deleted. |
@@ -103,7 +103,7 @@ | |||
gap: $grid-gap-desktop; | |||
grid-auto-columns: minmax(400px, 1fr); | |||
grid-auto-flow: column; | |||
grid-template-columns: repeat(auto-fill, minmax(400px, 1fr)); | |||
grid-template-columns: repeat(auto-fit, minmax(400px, 1fr)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @kuasha420, I noticed that the two-audience view was being laid out with an extra, unwanted grid column at wide viewports:
Changing the repeat value to auto-fit
fixes this in my testing; I've applied the change myself to save the round trip.
Size Change: +534 B (0%) Total Size: 1.43 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nice one @kuasha420!
Summary
Addresses issue:
Relevant technical choices
PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist