-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add reusable Widget area, New badge feature. #8737
Add reusable Widget area, New badge feature. #8737
Conversation
Waiting on #8138 to be merged then this one can be updated with develop and sent for review. |
Build files for e99a2ae have been deleted. |
Size Change: +989 B (+0.07%) Total Size: 1.51 MB
ℹ️ View Unchanged
|
99f453b
to
56f49f0
Compare
The failing test |
@@ -49,6 +49,9 @@ import WidgetCellWrapper from './WidgetCellWrapper'; | |||
import useViewOnly from '../../../hooks/useViewOnly'; | |||
import { CORE_USER } from '../../datastore/user/constants'; | |||
import useLatestIntersection from '../../../hooks/useLatestIntersection'; | |||
import NewBadge from '../../../components/NewBadge'; | |||
import { WEEK_IN_SECONDS } from '../../../util'; | |||
import { useDispatch } from '@wordpress/data'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just caught that this was used 😅
It won't cause any errors, but we try to import from googlesitekit-data
instead. Maybe we should add an ESLint rule about this; I know it autocompletes in VSCode a lot. I'll see if I can improve the suggestions in #8769. 🤔
Summary
Addresses issue:
Relevant technical choices
Implemented as in IB.
PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist