Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement audience selection panel #8751

Merged
merged 39 commits into from
Jun 5, 2024
Merged

Implement audience selection panel #8751

merged 39 commits into from
Jun 5, 2024

Commits on May 22, 2024

  1. Add AudienceSelectionPanel.

    @nfmohit
    nfmohit committed May 22, 2024
    Configuration menu
    Copy the full SHA
    43b4a47 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2024

  1. Update Checkbox to support meta information.

    @nfmohit
    nfmohit committed May 24, 2024
    Configuration menu
    Copy the full SHA
    759a006 View commit details
    Browse the repository at this point in the history

  2. Update SelectionBox to support meta information.

    @nfmohit
    nfmohit committed May 24, 2024
    Configuration menu
    Copy the full SHA
    8dcb08e View commit details
    Browse the repository at this point in the history

  3. Update SelectionPanelItem to support subtitle & meta information.

    @nfmohit
    nfmohit committed May 24, 2024
    Configuration menu
    Copy the full SHA
    b9127a4 View commit details
    Browse the repository at this point in the history

  4. Update styling to accommodate subtitle & meta information.

    @nfmohit
    nfmohit committed May 24, 2024
    Configuration menu
    Copy the full SHA
    6312845 View commit details
    Browse the repository at this point in the history

  5. Update AudienceItem to support subtitle & meta information.

    @nfmohit
    nfmohit committed May 24, 2024
    Configuration menu
    Copy the full SHA
    d17c3e6 View commit details
    Browse the repository at this point in the history

  6. Update AudienceItems to compose subtitle and calculate user count.

    @nfmohit
    nfmohit committed May 24, 2024
    Configuration menu
    Copy the full SHA
    d46f242 View commit details
    Browse the repository at this point in the history

  7. Use suffix in SelectionPanelItem instead of changing SelectionBox.

    @nfmohit
    nfmohit committed May 24, 2024
    Configuration menu
    Copy the full SHA
    6e2a39d View commit details
    Browse the repository at this point in the history

  8. Decrease padding only for audience selection panel.

    @nfmohit
    nfmohit committed May 24, 2024
    Configuration menu
    Copy the full SHA
    85ba3f0 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'develop' into enhancement/#8157-audience-selection-panel.

    @nfmohit
    nfmohit committed May 24, 2024
    Configuration menu
    Copy the full SHA
    84909c2 View commit details
    Browse the repository at this point in the history

  10. Add Footer.

    @nfmohit
    nfmohit committed May 24, 2024
    Configuration menu
    Copy the full SHA
    82f6ba0 View commit details
    Browse the repository at this point in the history

  11. Update footer layout in mobile viewport.

    @nfmohit
    nfmohit committed May 24, 2024
    Configuration menu
    Copy the full SHA
    1018efe View commit details
    Browse the repository at this point in the history

  12. Add learn more link.

    @nfmohit
    nfmohit committed May 24, 2024
    Configuration menu
    Copy the full SHA
    5c86de6 View commit details
    Browse the repository at this point in the history

Commits on May 25, 2024

  1. Update VRT references.

    @nfmohit
    nfmohit committed May 25, 2024
    Configuration menu
    Copy the full SHA
    66449f0 View commit details
    Browse the repository at this point in the history

  2. Fix border.

    @nfmohit
    nfmohit committed May 25, 2024
    Configuration menu
    Copy the full SHA
    aa4fad9 View commit details
    Browse the repository at this point in the history

  3. Add Storybook story.

    @nfmohit
    nfmohit committed May 25, 2024
    Configuration menu
    Copy the full SHA
    6c58dc6 View commit details
    Browse the repository at this point in the history

  4. Format user count.

    @nfmohit
    nfmohit committed May 25, 2024
    Configuration menu
    Copy the full SHA
    c9f1e44 View commit details
    Browse the repository at this point in the history

Commits on May 26, 2024

  1. Restore border and outline in SelectionBox.

    @nfmohit
    nfmohit committed May 26, 2024
    Configuration menu
    Copy the full SHA
    c4623cb View commit details
    Browse the repository at this point in the history

  2. Add test coverage for AudienceSelectionPanel.

    @nfmohit
    nfmohit committed May 26, 2024
    Configuration menu
    Copy the full SHA
    ab04e44 View commit details
    Browse the repository at this point in the history

  3. Add VRT references.

    @nfmohit
    nfmohit committed May 26, 2024
    Configuration menu
    Copy the full SHA
    e356292 View commit details
    Browse the repository at this point in the history

  4. Remove unnecessary white space.

    @nfmohit
    nfmohit committed May 26, 2024
    Configuration menu
    Copy the full SHA
    063d65a View commit details
    Browse the repository at this point in the history

Commits on May 31, 2024

  1. Merge branch 'develop' into enhancement/#8157-audience-selection-panel.

    @nfmohit
    nfmohit committed May 31, 2024
    Configuration menu
    Copy the full SHA
    7d7ebc0 View commit details
    Browse the repository at this point in the history

  2. Fix crash when audiences are not configured.

    @nfmohit
    nfmohit committed May 31, 2024
    Configuration menu
    Copy the full SHA
    71f8e37 View commit details
    Browse the repository at this point in the history

  3. Remove incorrect reference to key metrics selector.

    @nfmohit
    nfmohit committed May 31, 2024
    Configuration menu
    Copy the full SHA
    8d08a30 View commit details
    Browse the repository at this point in the history

  4. Remove incorrect references to metrics.

    @nfmohit
    nfmohit committed May 31, 2024
    Configuration menu
    Copy the full SHA
    acfe53f View commit details
    Browse the repository at this point in the history

  5. Add getConfigurableAudiences selector.

    @nfmohit
    nfmohit committed May 31, 2024
    Configuration menu
    Copy the full SHA
    78a306c View commit details
    Browse the repository at this point in the history

  6. Use getConfigurableAudiences.

    @nfmohit
    nfmohit committed May 31, 2024
    Configuration menu
    Copy the full SHA
    77606f4 View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2024

  1. Fix saved item logic.

    @nfmohit
    nfmohit committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    05500a1 View commit details
    Browse the repository at this point in the history

  2. Imrpove conditions and filtering audiences logic.

    @hussain-t
    hussain-t committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    4438c8e View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2024

  1. Merge branch 'develop' into enhancement/#8157-audience-selection-panel.

    @nfmohit
    nfmohit committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    df28c0b View commit details
    Browse the repository at this point in the history

  2. Apply BEM element-level class name.

    @nfmohit
    nfmohit committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    78f0780 View commit details
    Browse the repository at this point in the history

  3. Correctly reference savedItemSlugs.

    @nfmohit
    nfmohit committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    5be1183 View commit details
    Browse the repository at this point in the history

  4. Fix failing tests.

    @nfmohit
    nfmohit committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    6eae55b View commit details
    Browse the repository at this point in the history

  5. Remove unnecessary optional chaining.

    @nfmohit
    nfmohit committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    a577781 View commit details
    Browse the repository at this point in the history

  6. Show user count even if it is zero.

    @nfmohit
    nfmohit committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    4eac143 View commit details
    Browse the repository at this point in the history

  7. Fix casing for citation.

    @nfmohit
    nfmohit committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    f7c8cf0 View commit details
    Browse the repository at this point in the history

  8. Fix console error for story.

    @nfmohit
    nfmohit committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    2db9a16 View commit details
    Browse the repository at this point in the history

  9. Fix failing JS test.

    @nfmohit
    nfmohit committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    31de4e0 View commit details
    Browse the repository at this point in the history

  10. Update VRT references.

    @nfmohit
    nfmohit committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    d3714dd View commit details
    Browse the repository at this point in the history