Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement/7251 Restyle AdBlock Warning in Connect Services #8752

Merged
merged 19 commits into from
May 27, 2024
Merged

Enhancement/7251 Restyle AdBlock Warning in Connect Services #8752

merged 19 commits into from
May 27, 2024

Commits on May 24, 2024

  1. Remove disabled styling from connect more services.

    @jimmymadon
    jimmymadon committed May 24, 2024
    Configuration menu
    Copy the full SHA
    9e61622 View commit details
    Browse the repository at this point in the history

  2. Reorder Modules Setup Warning in connect services.

    @jimmymadon
    jimmymadon committed May 24, 2024
    Configuration menu
    Copy the full SHA
    e82d391 View commit details
    Browse the repository at this point in the history

  3. Create a generic version of the AdBlockerWarning component.

    @jimmymadon
    jimmymadon committed May 24, 2024
    Configuration menu
    Copy the full SHA
    82ca21c View commit details
    Browse the repository at this point in the history

  4. Move AdBlockerWarningMessage within notifications.

    @jimmymadon
    jimmymadon committed May 24, 2024
    Configuration menu
    Copy the full SHA
    93c1be0 View commit details
    Browse the repository at this point in the history

  5. Use the generic version of AdBlockerWarning within ModuleSettingsWarn… 

    …ing.
    @jimmymadon
    jimmymadon committed May 24, 2024
    Configuration menu
    Copy the full SHA
    5bfbb82 View commit details
    Browse the repository at this point in the history

  6. Update the default setup incomplete component to disable CTA.

    @jimmymadon
    jimmymadon committed May 24, 2024
    Configuration menu
    Copy the full SHA
    0aba91b View commit details
    Browse the repository at this point in the history

  7. Remove unnecessary custom setup incomplete component for Ads.

    @jimmymadon
    jimmymadon committed May 24, 2024
    Configuration menu
    Copy the full SHA
    233bbed View commit details
    Browse the repository at this point in the history

  8. Remove old duplicated AdBlockerWarning for AdSense.

    @jimmymadon
    jimmymadon committed May 24, 2024
    Configuration menu
    Copy the full SHA
    a351933 View commit details
    Browse the repository at this point in the history

  9. Remove old duplicated AdBlockerWarning for Ads.

    @jimmymadon
    jimmymadon committed May 24, 2024
    Configuration menu
    Copy the full SHA
    f70c06a View commit details
    Browse the repository at this point in the history

  10. Move AdBlockerWarningMessage to notifications.

    @jimmymadon
    jimmymadon committed May 24, 2024
    Configuration menu
    Copy the full SHA
    f0eb14b View commit details
    Browse the repository at this point in the history

  11. Use the common AdBlockerWarning component for Ads and AdSense.

    @jimmymadon
    jimmymadon committed May 24, 2024
    Configuration menu
    Copy the full SHA
    927fa3a View commit details
    Browse the repository at this point in the history

  12. Refactor tests for common AdBlockerWarinng component.

    @jimmymadon
    jimmymadon committed May 24, 2024
    Configuration menu
    Copy the full SHA
    3338b58 View commit details
    Browse the repository at this point in the history

  13. Reuse generic component for setup errors in AdSense.

    @jimmymadon
    jimmymadon committed May 24, 2024
    Configuration menu
    Copy the full SHA
    0fc0f92 View commit details
    Browse the repository at this point in the history

  14. Remove incorrect copy-pasted old comment.

    @jimmymadon
    jimmymadon committed May 24, 2024
    Configuration menu
    Copy the full SHA
    8bb3d93 View commit details
    Browse the repository at this point in the history

  15. Update stories to use new common AdBlockerWarning component.

    @jimmymadon
    jimmymadon committed May 24, 2024
    Configuration menu
    Copy the full SHA
    a0f987a View commit details
    Browse the repository at this point in the history

  16. Remove duplicated deprecated AdBlockerWarning story.

    @jimmymadon
    jimmymadon committed May 24, 2024
    Configuration menu
    Copy the full SHA
    2b448b4 View commit details
    Browse the repository at this point in the history

Commits on May 27, 2024

  1. Make storeName optional to fix all storybook stories.

    @jimmymadon
    jimmymadon committed May 27, 2024
    Configuration menu
    Copy the full SHA
    d6b7669 View commit details
    Browse the repository at this point in the history

  2. Use string interpolation instead of concatenation.

    @tofumatt
    tofumatt authored May 27, 2024
    Configuration menu
    Copy the full SHA
    284352d View commit details
    Browse the repository at this point in the history

  3. Fix whitespace issue.

    @tofumatt
    tofumatt committed May 27, 2024
    Configuration menu
    Copy the full SHA
    100cd86 View commit details
    Browse the repository at this point in the history