-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue / 8815 ICE Update _source
Event Param & Proxy Function Name
#8827
Merged
eugene-manuilov
merged 6 commits into
develop
from
issue/8815-ice-update-source-param-and-proxy-function-name
Jun 6, 2024
Merged
Issue / 8815 ICE Update _source
Event Param & Proxy Function Name
#8827
eugene-manuilov
merged 6 commits into
develop
from
issue/8815-ice-update-source-param-and-proxy-function-name
Jun 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Event, rename _source parameter to event_source.
…ckEvent to instead be gtagEvent.
Size Change: -3 B (0%) Total Size: 1.53 MB
ℹ️ View Unchanged
|
Build files for ce674a0 have been deleted. |
eugene-manuilov
approved these changes
Jun 6, 2024
eugene-manuilov
deleted the
issue/8815-ice-update-source-param-and-proxy-function-name
branch
June 6, 2024 15:58
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses issue:
_source
Parameter Used by Proxy Event Tracking Function Citing Site Kit as Source of ICE Events & RenametrackEvent
#8815Relevant technical choices
trackEvent
helper function name to instead begtagEvent
_source
event parameter within thegtag()
API call of above event, renamed it toevent_source
assets/js/event-providers
and changed references totrackEvent
to instead begtagEvent
given the function name changePR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist