Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue / 8815 ICE Update _source Event Param & Proxy Function Name #8827

Conversation

10upsimon
Copy link
Collaborator

@10upsimon 10upsimon commented Jun 6, 2024

Summary

Addresses issue:

Relevant technical choices

  • Updated the trackEvent helper function name to instead be gtagEvent
  • Updated the _source event parameter within the gtag() API call of above event, renamed it to event_source
  • Updated existing event provider JS logic in assets/js/event-providers and changed references to trackEvent to instead be gtagEvent given the function name change

PR Author Checklist

  • My code is tested and passes existing unit tests.
  • My code has an appropriate set of unit tests which all pass.
  • My code is backward-compatible with WordPress 5.2 and PHP 7.4.
  • My code follows the WordPress coding standards.
  • My code has proper inline documentation.
  • I have added a QA Brief on the issue linked above.
  • I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

  • Run the code.
  • Ensure the acceptance criteria are satisfied.
  • Reassess the implementation with the IB.
  • Ensure no unrelated changes are included.
  • Ensure CI checks pass.
  • Check Storybook where applicable.
  • Ensure there is a QA Brief.

Merge Reviewer Checklist

  • Ensure the PR has the correct target branch.
  • Double-check that the PR is okay to be merged.
  • Ensure the corresponding issue has a ZenHub release assigned.
  • Add a changelog message to the issue.

Copy link

github-actions bot commented Jun 6, 2024

Size Change: -3 B (0%)

Total Size: 1.53 MB

Filename Size Change
./dist/assets/js/contact-form-7-********************.js 645 B -1 B (-0.15%)
./dist/assets/js/optin-monster-********************.js 672 B +1 B (+0.15%)
./dist/assets/js/popup-maker-********************.js 633 B -1 B (-0.16%)
./dist/assets/js/woocommerce-********************.js 652 B -1 B (-0.15%)
./dist/assets/js/wpforms-********************.js 632 B -1 B (-0.16%)
ℹ️ View Unchanged
Filename Size
./dist/assets/css/googlesitekit-admin-css-********************.min.css 54.5 kB
./dist/assets/css/googlesitekit-adminbar-css-********************.min.css 11.2 kB
./dist/assets/css/googlesitekit-authorize-application-css-********************.min.css 770 B
./dist/assets/css/googlesitekit-wp-dashboard-css-********************.min.css 7.47 kB
./dist/assets/js/29-********************.js 2.76 kB
./dist/assets/js/30-********************.js 2.25 kB
./dist/assets/js/31-********************.js 3.64 kB
./dist/assets/js/32-********************.js 935 B
./dist/assets/js/33-********************.js 892 B
./dist/assets/js/34-********************.js 3.12 kB
./dist/assets/js/analytics-advanced-tracking-********************.js 776 B
./dist/assets/js/googlesitekit-activation-********************.js 24 kB
./dist/assets/js/googlesitekit-ad-blocking-recovery-********************.js 59.3 kB
./dist/assets/js/googlesitekit-adminbar-********************.js 34.7 kB
./dist/assets/js/googlesitekit-api-********************.js 10.1 kB
./dist/assets/js/googlesitekit-components-gm2-********************.js 5.88 kB
./dist/assets/js/googlesitekit-components-gm3-********************.js 10.1 kB
./dist/assets/js/googlesitekit-data-********************.js 2.18 kB
./dist/assets/js/googlesitekit-datastore-forms-********************.js 9.14 kB
./dist/assets/js/googlesitekit-datastore-location-********************.js 2.09 kB
./dist/assets/js/googlesitekit-datastore-site-********************.js 19.9 kB
./dist/assets/js/googlesitekit-datastore-ui-********************.js 10.1 kB
./dist/assets/js/googlesitekit-datastore-user-********************.js 25.2 kB
./dist/assets/js/googlesitekit-entity-dashboard-********************.js 73.8 kB
./dist/assets/js/googlesitekit-i18n-********************.js 3.92 kB
./dist/assets/js/googlesitekit-main-dashboard-********************.js 120 kB
./dist/assets/js/googlesitekit-modules-********************.js 22.2 kB
./dist/assets/js/googlesitekit-modules-ads-********************.js 29.2 kB
./dist/assets/js/googlesitekit-modules-adsense-********************.js 112 kB
./dist/assets/js/googlesitekit-modules-analytics-4-********************.js 134 kB
./dist/assets/js/googlesitekit-modules-pagespeed-insights-********************.js 22.6 kB
./dist/assets/js/googlesitekit-modules-search-console-********************.js 58.4 kB
./dist/assets/js/googlesitekit-modules-tagmanager-********************.js 30.5 kB
./dist/assets/js/googlesitekit-polyfills-********************.js 377 B
./dist/assets/js/googlesitekit-settings-********************.js 61.7 kB
./dist/assets/js/googlesitekit-splash-********************.js 72.6 kB
./dist/assets/js/googlesitekit-user-input-********************.js 48.2 kB
./dist/assets/js/googlesitekit-vendor-********************.js 317 kB
./dist/assets/js/googlesitekit-widgets-********************.js 54 kB
./dist/assets/js/googlesitekit-wp-dashboard-********************.js 60.1 kB
./dist/assets/js/mailchimp-********************.js 629 B
./dist/assets/js/runtime-********************.js 1.3 kB

compressed-size-action

Copy link

github-actions bot commented Jun 6, 2024

Build files for ce674a0 have been deleted.

@eugene-manuilov eugene-manuilov merged commit 1c40b02 into develop Jun 6, 2024
24 of 26 checks passed
@eugene-manuilov eugene-manuilov deleted the issue/8815-ice-update-source-param-and-proxy-function-name branch June 6, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants