Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audience selection panel style improvements #8829

Merged
merged 6 commits into from
Jun 11, 2024

Conversation

nfmohit
Copy link
Collaborator

@nfmohit nfmohit commented Jun 7, 2024

Summary

Addresses issue:

Relevant technical choices

This PR applies some stylistic improvements based on Figma to the audience selection panel:

  1. Reduces font-weight for selection panel subtitle.
  2. Changes font-family for selection panel checkbox labels.

PR Author Checklist

  • My code is tested and passes existing unit tests.
  • My code has an appropriate set of unit tests which all pass.
  • My code is backward-compatible with WordPress 5.2 and PHP 7.4.
  • My code follows the WordPress coding standards.
  • My code has proper inline documentation.
  • I have added a QA Brief on the issue linked above.
  • I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

  • Run the code.
  • Ensure the acceptance criteria are satisfied.
  • Reassess the implementation with the IB.
  • Ensure no unrelated changes are included.
  • Ensure CI checks pass.
  • Check Storybook where applicable.
  • Ensure there is a QA Brief.

Merge Reviewer Checklist

  • Ensure the PR has the correct target branch.
  • Double-check that the PR is okay to be merged.
  • Ensure the corresponding issue has a ZenHub release assigned.
  • Add a changelog message to the issue.

Copy link

github-actions bot commented Jun 7, 2024

Build files for 97bd374 have been deleted.

Copy link

github-actions bot commented Jun 7, 2024

Size Change: -5 B (0%)

Total Size: 1.53 MB

Filename Size Change
./dist/assets/css/googlesitekit-admin-css-********************.min.css 54.5 kB -5 B (-0.01%)
ℹ️ View Unchanged
Filename Size
./dist/assets/css/googlesitekit-adminbar-css-********************.min.css 11.2 kB
./dist/assets/css/googlesitekit-authorize-application-css-********************.min.css 770 B
./dist/assets/css/googlesitekit-wp-dashboard-css-********************.min.css 7.47 kB
./dist/assets/js/29-********************.js 2.76 kB
./dist/assets/js/30-********************.js 2.25 kB
./dist/assets/js/31-********************.js 3.64 kB
./dist/assets/js/32-********************.js 935 B
./dist/assets/js/33-********************.js 892 B
./dist/assets/js/34-********************.js 3.12 kB
./dist/assets/js/analytics-advanced-tracking-********************.js 776 B
./dist/assets/js/contact-form-7-********************.js 645 B
./dist/assets/js/googlesitekit-activation-********************.js 24.1 kB
./dist/assets/js/googlesitekit-ad-blocking-recovery-********************.js 59.5 kB
./dist/assets/js/googlesitekit-adminbar-********************.js 34.7 kB
./dist/assets/js/googlesitekit-api-********************.js 10.2 kB
./dist/assets/js/googlesitekit-components-gm2-********************.js 5.88 kB
./dist/assets/js/googlesitekit-components-gm3-********************.js 10.1 kB
./dist/assets/js/googlesitekit-data-********************.js 2.18 kB
./dist/assets/js/googlesitekit-datastore-forms-********************.js 9.14 kB
./dist/assets/js/googlesitekit-datastore-location-********************.js 2.08 kB
./dist/assets/js/googlesitekit-datastore-site-********************.js 19.9 kB
./dist/assets/js/googlesitekit-datastore-ui-********************.js 10.1 kB
./dist/assets/js/googlesitekit-datastore-user-********************.js 25.2 kB
./dist/assets/js/googlesitekit-entity-dashboard-********************.js 73.9 kB
./dist/assets/js/googlesitekit-i18n-********************.js 3.92 kB
./dist/assets/js/googlesitekit-main-dashboard-********************.js 121 kB
./dist/assets/js/googlesitekit-modules-********************.js 22.2 kB
./dist/assets/js/googlesitekit-modules-ads-********************.js 29.2 kB
./dist/assets/js/googlesitekit-modules-adsense-********************.js 112 kB
./dist/assets/js/googlesitekit-modules-analytics-4-********************.js 135 kB
./dist/assets/js/googlesitekit-modules-pagespeed-insights-********************.js 22.6 kB
./dist/assets/js/googlesitekit-modules-search-console-********************.js 58.5 kB
./dist/assets/js/googlesitekit-modules-tagmanager-********************.js 30.5 kB
./dist/assets/js/googlesitekit-polyfills-********************.js 376 B
./dist/assets/js/googlesitekit-settings-********************.js 61.7 kB
./dist/assets/js/googlesitekit-splash-********************.js 72.6 kB
./dist/assets/js/googlesitekit-user-input-********************.js 48.3 kB
./dist/assets/js/googlesitekit-vendor-********************.js 317 kB
./dist/assets/js/googlesitekit-widgets-********************.js 54.6 kB
./dist/assets/js/googlesitekit-wp-dashboard-********************.js 60.1 kB
./dist/assets/js/mailchimp-********************.js 629 B
./dist/assets/js/optin-monster-********************.js 672 B
./dist/assets/js/popup-maker-********************.js 633 B
./dist/assets/js/runtime-********************.js 1.3 kB
./dist/assets/js/woocommerce-********************.js 652 B
./dist/assets/js/wpforms-********************.js 632 B

compressed-size-action

Copy link
Contributor

@kuasha420 kuasha420 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nfmohit for the PR. Good to see more consistency between design and implementation. :tada Lots of VRT changes, but it's passing on CI and locally so we're good. 👍

@kuasha420 kuasha420 merged commit cb329f1 into develop Jun 11, 2024
20 of 21 checks passed
@kuasha420 kuasha420 deleted the enhancement/#8157-follow-up branch June 11, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants