Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add onClose prop to the Dialog component. #8832

Merged
merged 3 commits into from
Jun 10, 2024

Conversation

zutigrm
Copy link
Collaborator

@zutigrm zutigrm commented Jun 7, 2024

Summary

Addresses issue:

Relevant technical choices

  • Diverged a bit from the IB, by adding the onClose prop instead, which inherits onCancel prop. Since not all components where using handlePopup just to close it, 2 tests were failing, as they have custom listeners and additional logic. But onCancel is always used just for closing the popup

PR Author Checklist

  • My code is tested and passes existing unit tests.
  • My code has an appropriate set of unit tests which all pass.
  • My code is backward-compatible with WordPress 5.2 and PHP 7.4.
  • My code follows the WordPress coding standards.
  • My code has proper inline documentation.
  • I have added a QA Brief on the issue linked above.
  • I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

  • Run the code.
  • Ensure the acceptance criteria are satisfied.
  • Reassess the implementation with the IB.
  • Ensure no unrelated changes are included.
  • Ensure CI checks pass.
  • Check Storybook where applicable.
  • Ensure there is a QA Brief.

Merge Reviewer Checklist

  • Ensure the PR has the correct target branch.
  • Double-check that the PR is okay to be merged.
  • Ensure the corresponding issue has a ZenHub release assigned.
  • Add a changelog message to the issue.

Copy link

github-actions bot commented Jun 7, 2024

Build files for 6543677 have been deleted.

Copy link

github-actions bot commented Jun 7, 2024

Size Change: +257 B (+0.02%)

Total Size: 1.53 MB

Filename Size Change
./dist/assets/js/googlesitekit-activation-********************.js 24 kB +18 B (+0.07%)
./dist/assets/js/googlesitekit-ad-blocking-recovery-********************.js 59.4 kB +28 B (+0.05%)
./dist/assets/js/googlesitekit-adminbar-********************.js 34.7 kB +17 B (+0.05%)
./dist/assets/js/googlesitekit-entity-dashboard-********************.js 73.9 kB +18 B (+0.02%)
./dist/assets/js/googlesitekit-main-dashboard-********************.js 120 kB +21 B (+0.02%)
./dist/assets/js/googlesitekit-modules-ads-********************.js 29.1 kB +13 B (+0.04%)
./dist/assets/js/googlesitekit-modules-adsense-********************.js 112 kB +24 B (+0.02%)
./dist/assets/js/googlesitekit-modules-analytics-4-********************.js 134 kB +28 B (+0.02%)
./dist/assets/js/googlesitekit-settings-********************.js 61.7 kB +22 B (+0.04%)
./dist/assets/js/googlesitekit-splash-********************.js 72.6 kB +21 B (+0.03%)
./dist/assets/js/googlesitekit-user-input-********************.js 48.2 kB +21 B (+0.04%)
./dist/assets/js/googlesitekit-wp-dashboard-********************.js 60.2 kB +26 B (+0.04%)
ℹ️ View Unchanged
Filename Size
./dist/assets/css/googlesitekit-admin-css-********************.min.css 54.5 kB
./dist/assets/css/googlesitekit-adminbar-css-********************.min.css 11.2 kB
./dist/assets/css/googlesitekit-authorize-application-css-********************.min.css 770 B
./dist/assets/css/googlesitekit-wp-dashboard-css-********************.min.css 7.47 kB
./dist/assets/js/29-********************.js 2.76 kB
./dist/assets/js/30-********************.js 2.25 kB
./dist/assets/js/31-********************.js 3.64 kB
./dist/assets/js/32-********************.js 935 B
./dist/assets/js/33-********************.js 892 B
./dist/assets/js/34-********************.js 3.11 kB
./dist/assets/js/analytics-advanced-tracking-********************.js 776 B
./dist/assets/js/contact-form-7-********************.js 645 B
./dist/assets/js/googlesitekit-api-********************.js 10.1 kB
./dist/assets/js/googlesitekit-components-gm2-********************.js 5.88 kB
./dist/assets/js/googlesitekit-components-gm3-********************.js 10.1 kB
./dist/assets/js/googlesitekit-data-********************.js 2.18 kB
./dist/assets/js/googlesitekit-datastore-forms-********************.js 9.14 kB
./dist/assets/js/googlesitekit-datastore-location-********************.js 2.09 kB
./dist/assets/js/googlesitekit-datastore-site-********************.js 19.9 kB
./dist/assets/js/googlesitekit-datastore-ui-********************.js 10.1 kB
./dist/assets/js/googlesitekit-datastore-user-********************.js 25.2 kB
./dist/assets/js/googlesitekit-i18n-********************.js 3.92 kB
./dist/assets/js/googlesitekit-modules-********************.js 22.2 kB
./dist/assets/js/googlesitekit-modules-pagespeed-insights-********************.js 22.6 kB
./dist/assets/js/googlesitekit-modules-search-console-********************.js 58.4 kB
./dist/assets/js/googlesitekit-modules-tagmanager-********************.js 30.5 kB
./dist/assets/js/googlesitekit-polyfills-********************.js 376 B
./dist/assets/js/googlesitekit-vendor-********************.js 317 kB
./dist/assets/js/googlesitekit-widgets-********************.js 54 kB
./dist/assets/js/mailchimp-********************.js 629 B
./dist/assets/js/optin-monster-********************.js 672 B
./dist/assets/js/popup-maker-********************.js 633 B
./dist/assets/js/runtime-********************.js 1.3 kB
./dist/assets/js/woocommerce-********************.js 652 B
./dist/assets/js/wpforms-********************.js 632 B

compressed-size-action

Copy link
Collaborator

@benbowler benbowler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR ✅

@eugene-manuilov eugene-manuilov merged commit 76f1907 into develop Jun 10, 2024
20 of 22 checks passed
@eugene-manuilov eugene-manuilov deleted the bug/8818-toggle-modal-outside-click branch June 10, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants