Setup completion tracking #9052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build files for 715169e have been deleted. |
|
Size Change: +5.25 kB (+0.31%) Total Size: 1.67 MB
ℹ️ View Unchanged
|
aaemnnosttv
requested changes
Jul 22, 2024
There was a problem hiding this comment.
Thanks @zutigrm , this is quite close I think, just a few things to update and it should be good to go 👍
|
@aaemnnosttv Thanks, I updated the PR |
aaemnnosttv
reviewed
Jul 23, 2024
Comment on lines
40
to
42
| beforeAll( () => { | ||
| setStorageOrder( [ 'localStorage', 'sessionStorage' ] ); | ||
| } ); |
There was a problem hiding this comment.
Why are we setting this to prefer localStorage? I don't think it should be necessary to set/change.
There was a problem hiding this comment.
Since by default order it is setting sessionStorage for the storageBackend backend. And we are running this in test environment it made more sense to me to use localStorage for stability, even our storage mechanism prefers to use sessionStorage for some reason in these tests.
I wrote the tests to use localStorage in expect checks, but it was failing, and after digging I found that it was using sessionStorage instead, so I had to change the order to use localStorage
There was a problem hiding this comment.
Both are mocked so one shouldn't be more stable than another. It sounds like it was failing from checking the wrong storage but we shouldn't even need to be specific about which one and instead use our getStorage utility.
aaemnnosttv
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses issue:
Relevant technical choices
PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist