Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement/8847 RRM GA tracking #9179

Merged
merged 10 commits into from
Aug 19, 2024
Merged

Conversation

ankitrox
Copy link
Collaborator

@ankitrox ankitrox commented Aug 9, 2024

Summary

Addresses issue:

Relevant technical choices

PR Author Checklist

  • My code is tested and passes existing unit tests.
  • My code has an appropriate set of unit tests which all pass.
  • My code is backward-compatible with WordPress 5.2 and PHP 7.4.
  • My code follows the WordPress coding standards.
  • My code has proper inline documentation.
  • I have added a QA Brief on the issue linked above.
  • I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

  • Run the code.
  • Ensure the acceptance criteria are satisfied.
  • Reassess the implementation with the IB.
  • Ensure no unrelated changes are included.
  • Ensure CI checks pass.
  • Check Storybook where applicable.
  • Ensure there is a QA Brief.

Merge Reviewer Checklist

  • Ensure the PR has the correct target branch.
  • Double-check that the PR is okay to be merged.
  • Ensure the corresponding issue has a ZenHub release assigned.
  • Add a changelog message to the issue.

Copy link

github-actions bot commented Aug 9, 2024

Build files for 912af4c have been deleted.

Copy link

github-actions bot commented Aug 9, 2024

Size Change: +1.68 kB (+0.09%)

Total Size: 1.78 MB

Filename Size Change
./dist/assets/js/googlesitekit-activation-********************.js 23.9 kB +27 B (+0.11%)
./dist/assets/js/googlesitekit-ad-blocking-recovery-********************.js 70.9 kB +263 B (+0.37%)
./dist/assets/js/googlesitekit-adminbar-********************.js 34.5 kB -8 B (-0.02%)
./dist/assets/js/googlesitekit-api-********************.js 9.95 kB +1 B (+0.01%)
./dist/assets/js/googlesitekit-datastore-forms-********************.js 8.94 kB +2 B (+0.02%)
./dist/assets/js/googlesitekit-datastore-site-********************.js 20.3 kB -5 B (-0.02%)
./dist/assets/js/googlesitekit-datastore-ui-********************.js 9.88 kB +1 B (+0.01%)
./dist/assets/js/googlesitekit-datastore-user-********************.js 26 kB -39 B (-0.15%)
./dist/assets/js/googlesitekit-entity-dashboard-********************.js 83.2 kB +265 B (+0.32%)
./dist/assets/js/googlesitekit-main-dashboard-********************.js 152 kB +205 B (+0.13%)
./dist/assets/js/googlesitekit-modules-********************.js 22.1 kB -20 B (-0.09%)
./dist/assets/js/googlesitekit-modules-ads-********************.js 29.5 kB -28 B (-0.09%)
./dist/assets/js/googlesitekit-modules-adsense-********************.js 125 kB +218 B (+0.17%)
./dist/assets/js/googlesitekit-modules-analytics-4-********************.js 165 kB -26 B (-0.02%)
./dist/assets/js/googlesitekit-modules-pagespeed-insights-********************.js 22.4 kB +10 B (+0.04%)
./dist/assets/js/googlesitekit-modules-reader-revenue-manager-********************.js 20.5 kB +73 B (+0.36%)
./dist/assets/js/googlesitekit-modules-search-console-********************.js 58.5 kB +40 B (+0.07%)
./dist/assets/js/googlesitekit-modules-tagmanager-********************.js 31.9 kB -19 B (-0.06%)
./dist/assets/js/googlesitekit-notifications-********************.js 21.6 kB -32 B (-0.15%)
./dist/assets/js/googlesitekit-settings-********************.js 82.8 kB +214 B (+0.26%)
./dist/assets/js/googlesitekit-splash-********************.js 88.9 kB +298 B (+0.34%)
./dist/assets/js/googlesitekit-user-input-********************.js 62.8 kB +228 B (+0.36%)
./dist/assets/js/googlesitekit-widgets-********************.js 81.7 kB -14 B (-0.02%)
./dist/assets/js/googlesitekit-wp-dashboard-********************.js 61.7 kB +21 B (+0.03%)
ℹ️ View Unchanged
Filename Size
./dist/assets/css/googlesitekit-admin-css-********************.min.css 57 kB
./dist/assets/css/googlesitekit-adminbar-css-********************.min.css 11.8 kB
./dist/assets/css/googlesitekit-authorize-application-css-********************.min.css 846 B
./dist/assets/css/googlesitekit-wp-dashboard-css-********************.min.css 8.2 kB
./dist/assets/js/31-********************.js 2.76 kB
./dist/assets/js/32-********************.js 2.25 kB
./dist/assets/js/33-********************.js 3.64 kB
./dist/assets/js/34-********************.js 935 B
./dist/assets/js/35-********************.js 892 B
./dist/assets/js/36-********************.js 3.12 kB
./dist/assets/js/analytics-advanced-tracking-********************.js 901 B
./dist/assets/js/googlesitekit-components-gm2-********************.js 5.97 kB
./dist/assets/js/googlesitekit-components-gm3-********************.js 10.1 kB
./dist/assets/js/googlesitekit-consent-mode-********************.js 25.6 kB
./dist/assets/js/googlesitekit-data-********************.js 2.35 kB
./dist/assets/js/googlesitekit-datastore-location-********************.js 2.08 kB
./dist/assets/js/googlesitekit-events-provider-contact-form-7-********************.js 646 B
./dist/assets/js/googlesitekit-events-provider-easy-digital-downloads-********************.js 624 B
./dist/assets/js/googlesitekit-events-provider-mailchimp-********************.js 630 B
./dist/assets/js/googlesitekit-events-provider-ninja-forms-********************.js 712 B
./dist/assets/js/googlesitekit-events-provider-optin-monster-********************.js 675 B
./dist/assets/js/googlesitekit-events-provider-popup-maker-********************.js 634 B
./dist/assets/js/googlesitekit-events-provider-woocommerce-********************.js 657 B
./dist/assets/js/googlesitekit-events-provider-wpforms-********************.js 633 B
./dist/assets/js/googlesitekit-i18n-********************.js 3.93 kB
./dist/assets/js/googlesitekit-polyfills-********************.js 377 B
./dist/assets/js/googlesitekit-vendor-********************.js 321 kB
./dist/assets/js/runtime-********************.js 1.3 kB

compressed-size-action

Copy link
Collaborator

@techanvil techanvil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ankitrox, this is off to a good start. I've left a few comments for your consideration.

Furthermore, please can you add a QAB?

@ankitrox
Copy link
Collaborator Author

Thank you @techanvil for reviewing the PR.

I've addressed the feedback and sending it your way for another review.

Copy link
Collaborator

@techanvil techanvil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ankitrox! This is looking good, just one last minor point to address in the PR - I would have simply applied this myself, but the issue also still needs a QAB so I am sending it back your way.

Comment on lines 139 to 142
// eslint-disable-next-line require-await
await act( async () => {
fireEvent.click( getByText( ctaText ) );
} );
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I didn't notice this the first time round, but it doesn't look like this needs to be async either.

More importantly though - as per my previous comment, the issue still needs a QAB. Please can you add one?

Suggested change
// eslint-disable-next-line require-await
await act( async () => {
fireEvent.click( getByText( ctaText ) );
} );
act( () => {
fireEvent.click( getByText( ctaText ) );
} );

@ankitrox
Copy link
Collaborator Author

@techanvil Thank you. I've updated the QAB and removed async await mentioned.

Copy link
Collaborator

@techanvil techanvil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice one @ankitrox!

@techanvil techanvil merged commit e092cdb into develop Aug 19, 2024
19 of 21 checks passed
@techanvil techanvil deleted the enhancement/8847-rrm-ga-tracking branch August 19, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants