-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement/8847 RRM GA tracking #9179
Conversation
Build files for 912af4c have been deleted. |
Size Change: +1.68 kB (+0.09%) Total Size: 1.78 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ankitrox, this is off to a good start. I've left a few comments for your consideration.
Furthermore, please can you add a QAB?
...js/modules/reader-revenue-manager/components/dashboard/ReaderRevenueManagerSetupCTABanner.js
Outdated
Show resolved
Hide resolved
.../js/modules/reader-revenue-manager/components/dashboard/RRMSetupSuccessSubtleNotification.js
Outdated
Show resolved
Hide resolved
assets/js/modules/reader-revenue-manager/components/common/PublicationOnboardingStateNotice.js
Outdated
Show resolved
Hide resolved
.../js/modules/reader-revenue-manager/components/dashboard/RRMSetupSuccessSubtleNotification.js
Outdated
Show resolved
Hide resolved
.../js/modules/reader-revenue-manager/components/dashboard/RRMSetupSuccessSubtleNotification.js
Outdated
Show resolved
Hide resolved
...odules/reader-revenue-manager/components/dashboard/RRMSetupSuccessSubtleNotification.test.js
Outdated
Show resolved
Hide resolved
...odules/reader-revenue-manager/components/dashboard/RRMSetupSuccessSubtleNotification.test.js
Outdated
Show resolved
Hide resolved
...odules/reader-revenue-manager/components/dashboard/RRMSetupSuccessSubtleNotification.test.js
Outdated
Show resolved
Hide resolved
...odules/reader-revenue-manager/components/dashboard/RRMSetupSuccessSubtleNotification.test.js
Outdated
Show resolved
Hide resolved
...js/modules/reader-revenue-manager/components/dashboard/ReaderRevenueManagerSetupCTABanner.js
Outdated
Show resolved
Hide resolved
Thank you @techanvil for reviewing the PR. I've addressed the feedback and sending it your way for another review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ankitrox! This is looking good, just one last minor point to address in the PR - I would have simply applied this myself, but the issue also still needs a QAB so I am sending it back your way.
// eslint-disable-next-line require-await | ||
await act( async () => { | ||
fireEvent.click( getByText( ctaText ) ); | ||
} ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, I didn't notice this the first time round, but it doesn't look like this needs to be async either.
More importantly though - as per my previous comment, the issue still needs a QAB. Please can you add one?
// eslint-disable-next-line require-await | |
await act( async () => { | |
fireEvent.click( getByText( ctaText ) ); | |
} ); | |
act( () => { | |
fireEvent.click( getByText( ctaText ) ); | |
} ); |
@techanvil Thank you. I've updated the QAB and removed async await mentioned. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nice one @ankitrox!
Summary
Addresses issue:
Relevant technical choices
PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist