-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement/#8154 - Implement the “Top content” metric handling OAuth flow #9243
Conversation
Build files for 115c349 have been deleted. |
Size Change: +250 B (+0.01%) Total Size: 1.8 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @hussain-t - this is mostly working, but needs a bit of further attention as per my comments.
...-4/components/audience-segmentation/dashboard/AudienceTilesWidget/AudienceTile/index.test.js
Outdated
Show resolved
Hide resolved
...-4/components/audience-segmentation/dashboard/AudienceTilesWidget/AudienceTile/index.test.js
Outdated
Show resolved
Hide resolved
...-4/components/audience-segmentation/dashboard/AudienceTilesWidget/AudienceTile/index.test.js
Outdated
Show resolved
Hide resolved
...-4/components/audience-segmentation/dashboard/AudienceTilesWidget/AudienceTile/index.test.js
Outdated
Show resolved
Hide resolved
...-4/components/audience-segmentation/dashboard/AudienceTilesWidget/AudienceTile/index.test.js
Outdated
Show resolved
Hide resolved
...-4/components/audience-segmentation/dashboard/AudienceTilesWidget/AudienceTile/index.test.js
Outdated
Show resolved
Hide resolved
...-4/components/audience-segmentation/dashboard/AudienceTilesWidget/AudienceTile/index.test.js
Outdated
Show resolved
Hide resolved
...-4/components/audience-segmentation/dashboard/AudienceTilesWidget/AudienceTile/index.test.js
Outdated
Show resolved
Hide resolved
...-4/components/audience-segmentation/dashboard/AudienceTilesWidget/AudienceTile/index.test.js
Outdated
Show resolved
Hide resolved
.../audience-segmentation/dashboard/AudienceTilesWidget/AudienceTile/AudienceTilePagesMetric.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's great, thanks @hussain-t. LGTM!
Summary
Addresses issue:
Relevant technical choices
PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist