Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement/9132 acr datastore partial #9251

Merged
merged 7 commits into from
Aug 28, 2024

Conversation

zutigrm
Copy link
Collaborator

@zutigrm zutigrm commented Aug 28, 2024

Summary

Addresses issue:

Relevant technical choices

  • Only hasConversionReportingEvents selector is implemented, others are not needed since events are sourced from setting instead of inline data
  • recentEvents setting is renamed to detectedEvents as part of this issue

PR Author Checklist

  • My code is tested and passes existing unit tests.
  • My code has an appropriate set of unit tests which all pass.
  • My code is backward-compatible with WordPress 5.2 and PHP 7.4.
  • My code follows the WordPress coding standards.
  • My code has proper inline documentation.
  • I have added a QA Brief on the issue linked above.
  • I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

  • Run the code.
  • Ensure the acceptance criteria are satisfied.
  • Reassess the implementation with the IB.
  • Ensure no unrelated changes are included.
  • Ensure CI checks pass.
  • Check Storybook where applicable.
  • Ensure there is a QA Brief.

Merge Reviewer Checklist

  • Ensure the PR has the correct target branch.
  • Double-check that the PR is okay to be merged.
  • Ensure the corresponding issue has a ZenHub release assigned.
  • Add a changelog message to the issue.

Copy link

github-actions bot commented Aug 28, 2024

Size Change: +97 B (+0.01%)

Total Size: 1.79 MB

Filename Size Change
./dist/assets/js/googlesitekit-main-dashboard-********************.js 155 kB +17 B (+0.01%)
./dist/assets/js/googlesitekit-modules-analytics-4-********************.js 168 kB +65 B (+0.04%)
./dist/assets/js/googlesitekit-widgets-********************.js 85.2 kB +15 B (+0.02%)
ℹ️ View Unchanged
Filename Size
./dist/assets/css/googlesitekit-admin-css-********************.min.css 57.5 kB
./dist/assets/css/googlesitekit-adminbar-css-********************.min.css 11.8 kB
./dist/assets/css/googlesitekit-authorize-application-css-********************.min.css 846 B
./dist/assets/css/googlesitekit-wp-dashboard-css-********************.min.css 8.2 kB
./dist/assets/js/31-********************.js 2.76 kB
./dist/assets/js/32-********************.js 2.25 kB
./dist/assets/js/33-********************.js 3.64 kB
./dist/assets/js/34-********************.js 935 B
./dist/assets/js/35-********************.js 892 B
./dist/assets/js/36-********************.js 3.12 kB
./dist/assets/js/analytics-advanced-tracking-********************.js 901 B
./dist/assets/js/googlesitekit-activation-********************.js 23.8 kB
./dist/assets/js/googlesitekit-ad-blocking-recovery-********************.js 72.5 kB
./dist/assets/js/googlesitekit-adminbar-********************.js 34.5 kB
./dist/assets/js/googlesitekit-api-********************.js 9.99 kB
./dist/assets/js/googlesitekit-components-gm2-********************.js 5.97 kB
./dist/assets/js/googlesitekit-components-gm3-********************.js 10.1 kB
./dist/assets/js/googlesitekit-consent-mode-********************.js 25.6 kB
./dist/assets/js/googlesitekit-data-********************.js 2.35 kB
./dist/assets/js/googlesitekit-datastore-forms-********************.js 8.96 kB
./dist/assets/js/googlesitekit-datastore-location-********************.js 2.08 kB
./dist/assets/js/googlesitekit-datastore-site-********************.js 20.4 kB
./dist/assets/js/googlesitekit-datastore-ui-********************.js 9.91 kB
./dist/assets/js/googlesitekit-datastore-user-********************.js 26.1 kB
./dist/assets/js/googlesitekit-entity-dashboard-********************.js 83.9 kB
./dist/assets/js/googlesitekit-events-provider-contact-form-7-********************.js 646 B
./dist/assets/js/googlesitekit-events-provider-easy-digital-downloads-********************.js 624 B
./dist/assets/js/googlesitekit-events-provider-mailchimp-********************.js 630 B
./dist/assets/js/googlesitekit-events-provider-ninja-forms-********************.js 712 B
./dist/assets/js/googlesitekit-events-provider-optin-monster-********************.js 675 B
./dist/assets/js/googlesitekit-events-provider-popup-maker-********************.js 634 B
./dist/assets/js/googlesitekit-events-provider-woocommerce-********************.js 657 B
./dist/assets/js/googlesitekit-events-provider-wpforms-********************.js 633 B
./dist/assets/js/googlesitekit-i18n-********************.js 3.93 kB
./dist/assets/js/googlesitekit-modules-********************.js 22.2 kB
./dist/assets/js/googlesitekit-modules-ads-********************.js 29.5 kB
./dist/assets/js/googlesitekit-modules-adsense-********************.js 125 kB
./dist/assets/js/googlesitekit-modules-pagespeed-insights-********************.js 22.6 kB
./dist/assets/js/googlesitekit-modules-reader-revenue-manager-********************.js 21.4 kB
./dist/assets/js/googlesitekit-modules-search-console-********************.js 58.6 kB
./dist/assets/js/googlesitekit-modules-tagmanager-********************.js 31.9 kB
./dist/assets/js/googlesitekit-notifications-********************.js 16.3 kB
./dist/assets/js/googlesitekit-polyfills-********************.js 378 B
./dist/assets/js/googlesitekit-settings-********************.js 82.7 kB
./dist/assets/js/googlesitekit-splash-********************.js 88.9 kB
./dist/assets/js/googlesitekit-user-input-********************.js 62.7 kB
./dist/assets/js/googlesitekit-vendor-********************.js 321 kB
./dist/assets/js/googlesitekit-wp-dashboard-********************.js 61.6 kB
./dist/assets/js/runtime-********************.js 1.3 kB

compressed-size-action

Copy link

github-actions bot commented Aug 28, 2024

Build files for 7975258 are ready:

Copy link
Collaborator

@tofumatt tofumatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a typo here, but after that good-to-go 👍🏻

@tofumatt tofumatt merged commit a1e4685 into develop Aug 28, 2024
17 of 19 checks passed
@tofumatt tofumatt deleted the enhancement/9132-acr-datastore-partial branch August 28, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants