-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup multiple dismissals for CTA banner along with tooltip. #9306
Setup multiple dismissals for CTA banner along with tooltip. #9306
Conversation
Build files for 107a1d0 have been deleted. |
Size Change: +6.05 kB (+0.34%) Total Size: 1.8 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ankitrox, this is looking good, but is missing the requirement to change the dismissal CTA to "Don’t show again" on the second showing of the banner.
@techanvil Thanks for looking into it. I've updated the condition for displaying the CTA text. Moving it to CR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nice one @ankitrox!
Summary
Addresses issue:
Relevant technical choices
PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist