-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement/#8166 - Implement the unhappy paths for the Audience Creation Notice #9359
Enhancement/#8166 - Implement the unhappy paths for the Audience Creation Notice #9359
Conversation
Build files for 348dffc have been deleted. |
Size Change: +2.46 kB (+0.13%) Total Size: 1.86 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work on this, @hussain-t !
I have left a few comments on the PR which I hope should be quick to address, including some questions as well.
Thank you!
...onents/audience-segmentation/dashboard/AudienceSelectionPanel/AudienceCreationErrorNotice.js
Show resolved
Hide resolved
...udience-segmentation/dashboard/AudienceSelectionPanel/AudienceCreationErrorNotice.stories.js
Outdated
Show resolved
Hide resolved
...alytics-4/components/audience-segmentation/dashboard/AudienceSelectionPanel/index.stories.js
Outdated
Show resolved
Hide resolved
.../analytics-4/components/audience-segmentation/dashboard/AudienceSelectionPanel/index.test.js
Outdated
Show resolved
Hide resolved
...ss/components/analytics-4/audience-segmentation/_googlesitekit-audience-selection-panel.scss
Outdated
Show resolved
Hide resolved
...ss/components/analytics-4/audience-segmentation/_googlesitekit-audience-selection-panel.scss
Outdated
Show resolved
Hide resolved
...ss/components/analytics-4/audience-segmentation/_googlesitekit-audience-selection-panel.scss
Outdated
Show resolved
Hide resolved
...ss/components/analytics-4/audience-segmentation/_googlesitekit-audience-selection-panel.scss
Show resolved
Hide resolved
...ss/components/analytics-4/audience-segmentation/_googlesitekit-audience-selection-panel.scss
Outdated
Show resolved
Hide resolved
Thanks for your kind review, @nfmohit. I have addressed the feedback and sent it back to you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the updates, @hussain-t ! PR LGTM ✅ 👍
Note: I've verified that the failing E2E and VRT tests in CI are unrelated to this PR.
Summary
Addresses issue:
Relevant technical choices
PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist