Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement/#8166 - Implement the unhappy paths for the Audience Creation Notice #9359

Merged

Conversation

hussain-t
Copy link
Collaborator

@hussain-t hussain-t commented Sep 16, 2024

Summary

Addresses issue:

Relevant technical choices

PR Author Checklist

  • My code is tested and passes existing unit tests.
  • My code has an appropriate set of unit tests which all pass.
  • My code is backward-compatible with WordPress 5.2 and PHP 7.4.
  • My code follows the WordPress coding standards.
  • My code has proper inline documentation.
  • I have added a QA Brief on the issue linked above.
  • I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

  • Run the code.
  • Ensure the acceptance criteria are satisfied.
  • Reassess the implementation with the IB.
  • Ensure no unrelated changes are included.
  • Ensure CI checks pass.
  • Check Storybook where applicable.
  • Ensure there is a QA Brief.
  • Ensure there are no unexpected significant changes to file sizes.

Merge Reviewer Checklist

  • Ensure the PR has the correct target branch.
  • Double-check that the PR is okay to be merged.
  • Ensure the corresponding issue has a ZenHub release assigned.
  • Add a changelog message to the issue.

Copy link

github-actions bot commented Sep 16, 2024

Build files for 348dffc have been deleted.

Copy link

github-actions bot commented Sep 16, 2024

Size Change: +2.46 kB (+0.13%)

Total Size: 1.86 MB

Filename Size Change
./dist/assets/css/googlesitekit-admin-css-********************.min.css 57.6 kB +83 B (+0.14%)
./dist/assets/js/googlesitekit-activation-********************.js 23.9 kB +4 B (+0.02%)
./dist/assets/js/googlesitekit-ad-blocking-recovery-********************.js 72.5 kB +4 B (+0.01%)
./dist/assets/js/googlesitekit-adminbar-********************.js 34.6 kB +11 B (+0.03%)
./dist/assets/js/googlesitekit-api-********************.js 9.96 kB -4 B (-0.04%)
./dist/assets/js/googlesitekit-components-gm2-********************.js 5.96 kB -3 B (-0.05%)
./dist/assets/js/googlesitekit-components-gm3-********************.js 10.1 kB -1 B (-0.01%)
./dist/assets/js/googlesitekit-datastore-forms-********************.js 8.95 kB -1 B (-0.01%)
./dist/assets/js/googlesitekit-datastore-site-********************.js 20.4 kB +6 B (+0.03%)
./dist/assets/js/googlesitekit-datastore-ui-********************.js 9.91 kB -2 B (-0.02%)
./dist/assets/js/googlesitekit-datastore-user-********************.js 26.2 kB +2 B (+0.01%)
./dist/assets/js/googlesitekit-entity-dashboard-********************.js 83.4 kB +3 B (0%)
./dist/assets/js/googlesitekit-main-dashboard-********************.js 157 kB +533 B (+0.34%)
./dist/assets/js/googlesitekit-modules-ads-********************.js 32.7 kB +17 B (+0.05%)
./dist/assets/js/googlesitekit-modules-adsense-********************.js 125 kB +13 B (+0.01%)
./dist/assets/js/googlesitekit-modules-analytics-4-********************.js 171 kB +682 B (+0.4%)
./dist/assets/js/googlesitekit-modules-reader-revenue-manager-********************.js 21.9 kB +17 B (+0.08%)
./dist/assets/js/googlesitekit-modules-search-console-********************.js 58.8 kB +4 B (+0.01%)
./dist/assets/js/googlesitekit-modules-tagmanager-********************.js 32 kB +3 B (+0.01%)
./dist/assets/js/googlesitekit-notifications-********************.js 18.6 kB +17 B (+0.09%)
./dist/assets/js/googlesitekit-settings-********************.js 129 kB +598 B (+0.47%)
./dist/assets/js/googlesitekit-splash-********************.js 90.9 kB +3 B (0%)
./dist/assets/js/googlesitekit-user-input-********************.js 64.3 kB -4 B (-0.01%)
./dist/assets/js/googlesitekit-vendor-********************.js 321 kB +7 B (0%)
./dist/assets/js/googlesitekit-widgets-********************.js 88.4 kB +457 B (+0.52%)
./dist/assets/js/googlesitekit-wp-dashboard-********************.js 62 kB +6 B (+0.01%)
./dist/assets/js/runtime-********************.js 1.3 kB +4 B (+0.31%)
ℹ️ View Unchanged
Filename Size
./dist/assets/css/googlesitekit-adminbar-css-********************.min.css 11.8 kB
./dist/assets/css/googlesitekit-authorize-application-css-********************.min.css 846 B
./dist/assets/css/googlesitekit-wp-dashboard-css-********************.min.css 8.2 kB
./dist/assets/js/31-********************.js 2.76 kB
./dist/assets/js/32-********************.js 2.25 kB
./dist/assets/js/33-********************.js 3.64 kB
./dist/assets/js/34-********************.js 935 B
./dist/assets/js/35-********************.js 892 B
./dist/assets/js/36-********************.js 3.12 kB
./dist/assets/js/analytics-advanced-tracking-********************.js 901 B
./dist/assets/js/googlesitekit-consent-mode-********************.js 25.6 kB
./dist/assets/js/googlesitekit-data-********************.js 2.37 kB
./dist/assets/js/googlesitekit-datastore-location-********************.js 2.08 kB
./dist/assets/js/googlesitekit-events-provider-contact-form-7-********************.js 646 B
./dist/assets/js/googlesitekit-events-provider-easy-digital-downloads-********************.js 624 B
./dist/assets/js/googlesitekit-events-provider-mailchimp-********************.js 630 B
./dist/assets/js/googlesitekit-events-provider-ninja-forms-********************.js 712 B
./dist/assets/js/googlesitekit-events-provider-optin-monster-********************.js 675 B
./dist/assets/js/googlesitekit-events-provider-popup-maker-********************.js 634 B
./dist/assets/js/googlesitekit-events-provider-woocommerce-********************.js 657 B
./dist/assets/js/googlesitekit-events-provider-wpforms-********************.js 633 B
./dist/assets/js/googlesitekit-i18n-********************.js 3.93 kB
./dist/assets/js/googlesitekit-modules-********************.js 22.1 kB
./dist/assets/js/googlesitekit-modules-pagespeed-insights-********************.js 22.5 kB
./dist/assets/js/googlesitekit-polyfills-********************.js 377 B

compressed-size-action

Copy link
Collaborator

@nfmohit nfmohit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work on this, @hussain-t !

I have left a few comments on the PR which I hope should be quick to address, including some questions as well.

Thank you!

@hussain-t
Copy link
Collaborator Author

Thanks for your kind review, @nfmohit. I have addressed the feedback and sent it back to you.

Copy link
Collaborator

@nfmohit nfmohit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the updates, @hussain-t ! PR LGTM ✅ 👍

Note: I've verified that the failing E2E and VRT tests in CI are unrelated to this PR.

@nfmohit nfmohit merged commit d8f9216 into develop Sep 24, 2024
18 of 21 checks passed
@nfmohit nfmohit deleted the enhancement/#8166-audience-creation-notice-unhappy-paths branch September 24, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants