Top traffic source driving purchases #9393
Merged
+492
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build files for 34d209d have been deleted. |
|
Size Change: +1.6 kB (+0.09%) Total Size: 1.85 MB
ℹ️ View Unchanged
|
10upsimon
requested changes
Sep 26, 2024
assets/js/modules/analytics-4/components/widgets/TopTrafficSourceDrivingPurchasesWidget.js
Outdated
Show resolved
Hide resolved
Co-authored-by: Simon Dowdles <[email protected]>
eugene-manuilov
requested changes
Sep 27, 2024
There was a problem hiding this comment.
Thanks, @zutigrm. Added two comments that are similar to ones I have added to the add_to_card widget. Please, take a look.
assets/js/modules/analytics-4/components/widgets/TopTrafficSourceDrivingPurchasesWidget.js
Show resolved
Hide resolved
Comment on lines
206
to
209
| // eslint-disable-next-line @wordpress/valid-sprintf | ||
| sprintf( | ||
| /* translators: %d: Percentage of leads for the current top traffic source compared to the number of total leads for all traffic sources. */ | ||
| __( '%s of total purchases', 'google-site-kit' ), |
There was a problem hiding this comment.
Please, fix the comment for the translation string to have correct placeholders.
eugene-manuilov
requested changes
Sep 30, 2024
assets/js/modules/analytics-4/components/widgets/TopTrafficSourceDrivingPurchasesWidget.js
Outdated
Show resolved
Hide resolved
…rceDrivingPurchasesWidget.js
…raffic-source-purchases.
eugene-manuilov
approved these changes
Sep 30, 2024
eugene-manuilov
deleted the
feature/9164-top-traffic-source-purchases
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses issue:
Top traffic source driving purchasesACR KMW #9164Relevant technical choices
PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist