Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure the "Top content" CTA for creating the custom dimension appears when the corresponding report error shows the custom dimension is missing. #9398

Merged

Conversation

techanvil
Copy link
Collaborator

@techanvil techanvil commented Sep 23, 2024

Summary

Additionally, don't show the CTA if the error appears in a view-only context.

Addresses issue:

Relevant technical choices

PR Author Checklist

  • My code is tested and passes existing unit tests.
  • My code has an appropriate set of unit tests which all pass.
  • My code is backward-compatible with WordPress 5.2 and PHP 7.4.
  • My code follows the WordPress coding standards.
  • My code has proper inline documentation.
  • I have added a QA Brief on the issue linked above.
  • I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

  • Run the code.
  • Ensure the acceptance criteria are satisfied.
  • Reassess the implementation with the IB.
  • Ensure no unrelated changes are included.
  • Ensure CI checks pass.
  • Check Storybook where applicable.
  • Ensure there is a QA Brief.
  • Ensure there are no unexpected significant changes to file sizes.

Merge Reviewer Checklist

  • Ensure the PR has the correct target branch.
  • Double-check that the PR is okay to be merged.
  • Ensure the corresponding issue has a ZenHub release assigned.
  • Add a changelog message to the issue.

Copy link

github-actions bot commented Sep 23, 2024

Build files for a74da78 have been deleted.

Copy link

github-actions bot commented Sep 23, 2024

Size Change: +925 B (+0.05%)

Total Size: 1.86 MB

Filename Size Change
./dist/assets/js/googlesitekit-activation-********************.js 23.9 kB +6 B (+0.03%)
./dist/assets/js/googlesitekit-ad-blocking-recovery-********************.js 72.5 kB -7 B (-0.01%)
./dist/assets/js/googlesitekit-adminbar-********************.js 34.6 kB +9 B (+0.03%)
./dist/assets/js/googlesitekit-api-********************.js 9.97 kB +2 B (+0.02%)
./dist/assets/js/googlesitekit-components-gm2-********************.js 5.96 kB -1 B (-0.02%)
./dist/assets/js/googlesitekit-data-********************.js 2.37 kB +2 B (+0.08%)
./dist/assets/js/googlesitekit-datastore-site-********************.js 20.4 kB -6 B (-0.03%)
./dist/assets/js/googlesitekit-datastore-user-********************.js 26.2 kB +1 B (0%)
./dist/assets/js/googlesitekit-entity-dashboard-********************.js 83.4 kB -4 B (0%)
./dist/assets/js/googlesitekit-main-dashboard-********************.js 158 kB +242 B (+0.15%)
./dist/assets/js/googlesitekit-modules-ads-********************.js 32.7 kB +2 B (+0.01%)
./dist/assets/js/googlesitekit-modules-adsense-********************.js 125 kB -27 B (-0.02%)
./dist/assets/js/googlesitekit-modules-analytics-4-********************.js 172 kB +192 B (+0.11%)
./dist/assets/js/googlesitekit-modules-pagespeed-insights-********************.js 22.5 kB +2 B (+0.01%)
./dist/assets/js/googlesitekit-modules-reader-revenue-manager-********************.js 21.9 kB +2 B (+0.01%)
./dist/assets/js/googlesitekit-modules-search-console-********************.js 58.8 kB +7 B (+0.01%)
./dist/assets/js/googlesitekit-modules-tagmanager-********************.js 32 kB +8 B (+0.02%)
./dist/assets/js/googlesitekit-notifications-********************.js 18.6 kB -1 B (-0.01%)
./dist/assets/js/googlesitekit-settings-********************.js 129 kB +238 B (+0.19%)
./dist/assets/js/googlesitekit-splash-********************.js 90.6 kB +7 B (+0.01%)
./dist/assets/js/googlesitekit-user-input-********************.js 64.3 kB +6 B (+0.01%)
./dist/assets/js/googlesitekit-vendor-********************.js 321 kB -4 B (0%)
./dist/assets/js/googlesitekit-widgets-********************.js 88.7 kB +256 B (+0.29%)
./dist/assets/js/googlesitekit-wp-dashboard-********************.js 62 kB -7 B (-0.01%)
ℹ️ View Unchanged
Filename Size
./dist/assets/css/googlesitekit-admin-css-********************.min.css 57.6 kB
./dist/assets/css/googlesitekit-adminbar-css-********************.min.css 11.8 kB
./dist/assets/css/googlesitekit-authorize-application-css-********************.min.css 846 B
./dist/assets/css/googlesitekit-wp-dashboard-css-********************.min.css 8.2 kB
./dist/assets/js/31-********************.js 2.76 kB
./dist/assets/js/32-********************.js 2.25 kB
./dist/assets/js/33-********************.js 3.64 kB
./dist/assets/js/34-********************.js 935 B
./dist/assets/js/35-********************.js 892 B
./dist/assets/js/36-********************.js 3.12 kB
./dist/assets/js/analytics-advanced-tracking-********************.js 901 B
./dist/assets/js/googlesitekit-components-gm3-********************.js 10.1 kB
./dist/assets/js/googlesitekit-consent-mode-********************.js 25.6 kB
./dist/assets/js/googlesitekit-datastore-forms-********************.js 8.95 kB
./dist/assets/js/googlesitekit-datastore-location-********************.js 2.08 kB
./dist/assets/js/googlesitekit-datastore-ui-********************.js 9.92 kB
./dist/assets/js/googlesitekit-events-provider-contact-form-7-********************.js 646 B
./dist/assets/js/googlesitekit-events-provider-easy-digital-downloads-********************.js 624 B
./dist/assets/js/googlesitekit-events-provider-mailchimp-********************.js 630 B
./dist/assets/js/googlesitekit-events-provider-ninja-forms-********************.js 712 B
./dist/assets/js/googlesitekit-events-provider-optin-monster-********************.js 675 B
./dist/assets/js/googlesitekit-events-provider-popup-maker-********************.js 634 B
./dist/assets/js/googlesitekit-events-provider-woocommerce-********************.js 657 B
./dist/assets/js/googlesitekit-events-provider-wpforms-********************.js 633 B
./dist/assets/js/googlesitekit-i18n-********************.js 3.93 kB
./dist/assets/js/googlesitekit-modules-********************.js 22.1 kB
./dist/assets/js/googlesitekit-polyfills-********************.js 377 B
./dist/assets/js/runtime-********************.js 1.3 kB

compressed-size-action

@techanvil techanvil force-pushed the enhancement/9218-sync-top-content-cta-on-report-error branch from a37451c to a74da78 Compare September 24, 2024 10:56
Copy link
Collaborator

@hussain-t hussain-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work, @techanvil! LGTM 👍

Note: I've verified that the CI build failures are unrelated to this PR.

@hussain-t hussain-t merged commit 165c8bb into develop Sep 25, 2024
18 of 21 checks passed
@hussain-t hussain-t deleted the enhancement/9218-sync-top-content-cta-on-report-error branch September 25, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants