-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure the "Top content" CTA for creating the custom dimension appears when the corresponding report error shows the custom dimension is missing. #9398
Merged
hussain-t
merged 5 commits into
develop
from
enhancement/9218-sync-top-content-cta-on-report-error
Sep 25, 2024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build files for a74da78 have been deleted. |
Size Change: +925 B (+0.05%) Total Size: 1.86 MB
ℹ️ View Unchanged
|
techanvil
commented
Sep 24, 2024
...ponents/audience-segmentation/dashboard/AudienceTilesWidget/__snapshots__/index.test.js.snap
Show resolved
Hide resolved
techanvil
commented
Sep 24, 2024
...egmentation_Dashboard_AudienceTilesWidget_DefaultAudiencesPartialData_0_document_0_small.png
Show resolved
Hide resolved
techanvil
force-pushed
the
enhancement/9218-sync-top-content-cta-on-report-error
branch
from
September 24, 2024 10:56
a37451c
to
a74da78
Compare
hussain-t
approved these changes
Sep 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work, @techanvil! LGTM 👍
Note: I've verified that the CI build failures are unrelated to this PR.
hussain-t
deleted the
enhancement/9218-sync-top-content-cta-on-report-error
branch
September 25, 2024 12:14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Additionally, don't show the CTA if the error appears in a view-only context.
Addresses issue:
Relevant technical choices
PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist