Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement/#7642 - Adsense Alerts UI fixes #9435

Merged
merged 2 commits into from
Oct 2, 2024

Conversation

hussain-t
Copy link
Collaborator

@hussain-t hussain-t commented Sep 30, 2024

Summary

Addresses issue:

Relevant technical choices

PR Author Checklist

  • My code is tested and passes existing unit tests.
  • My code has an appropriate set of unit tests which all pass.
  • My code is backward-compatible with WordPress 5.2 and PHP 7.4.
  • My code follows the WordPress coding standards.
  • My code has proper inline documentation.
  • I have added a QA Brief on the issue linked above.
  • I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

  • Run the code.
  • Ensure the acceptance criteria are satisfied.
  • Reassess the implementation with the IB.
  • Ensure no unrelated changes are included.
  • Ensure CI checks pass.
  • Check Storybook where applicable.
  • Ensure there is a QA Brief.
  • Ensure there are no unexpected significant changes to file sizes.

Merge Reviewer Checklist

  • Ensure the PR has the correct target branch.
  • Double-check that the PR is okay to be merged.
  • Ensure the corresponding issue has a ZenHub release assigned.
  • Add a changelog message to the issue.

Copy link

github-actions bot commented Sep 30, 2024

Build files for ebefdff have been deleted.

Copy link

Size Change: +38 B (0%)

Total Size: 1.85 MB

Filename Size Change
./dist/assets/css/googlesitekit-admin-css-********************.min.css 58.1 kB +33 B (+0.06%)
./dist/assets/js/googlesitekit-main-dashboard-********************.js 155 kB +5 B (0%)
ℹ️ View Unchanged
Filename Size
./dist/assets/css/googlesitekit-adminbar-css-********************.min.css 11.8 kB
./dist/assets/css/googlesitekit-authorize-application-css-********************.min.css 846 B
./dist/assets/css/googlesitekit-wp-dashboard-css-********************.min.css 8.2 kB
./dist/assets/js/32-********************.js 2.76 kB
./dist/assets/js/33-********************.js 2.25 kB
./dist/assets/js/34-********************.js 3.64 kB
./dist/assets/js/35-********************.js 935 B
./dist/assets/js/36-********************.js 891 B
./dist/assets/js/37-********************.js 3.12 kB
./dist/assets/js/analytics-advanced-tracking-********************.js 901 B
./dist/assets/js/googlesitekit-activation-********************.js 24 kB
./dist/assets/js/googlesitekit-ad-blocking-recovery-********************.js 70.3 kB
./dist/assets/js/googlesitekit-adminbar-********************.js 34.9 kB
./dist/assets/js/googlesitekit-api-********************.js 10 kB
./dist/assets/js/googlesitekit-components-gm2-********************.js 5.96 kB
./dist/assets/js/googlesitekit-components-gm3-********************.js 10.1 kB
./dist/assets/js/googlesitekit-consent-mode-********************.js 25.6 kB
./dist/assets/js/googlesitekit-data-********************.js 2.37 kB
./dist/assets/js/googlesitekit-datastore-forms-********************.js 8.95 kB
./dist/assets/js/googlesitekit-datastore-location-********************.js 2.08 kB
./dist/assets/js/googlesitekit-datastore-site-********************.js 20.4 kB
./dist/assets/js/googlesitekit-datastore-ui-********************.js 9.96 kB
./dist/assets/js/googlesitekit-datastore-user-********************.js 26.3 kB
./dist/assets/js/googlesitekit-entity-dashboard-********************.js 81.7 kB
./dist/assets/js/googlesitekit-events-provider-contact-form-7-********************.js 646 B
./dist/assets/js/googlesitekit-events-provider-easy-digital-downloads-********************.js 624 B
./dist/assets/js/googlesitekit-events-provider-mailchimp-********************.js 630 B
./dist/assets/js/googlesitekit-events-provider-ninja-forms-********************.js 712 B
./dist/assets/js/googlesitekit-events-provider-optin-monster-********************.js 675 B
./dist/assets/js/googlesitekit-events-provider-popup-maker-********************.js 634 B
./dist/assets/js/googlesitekit-events-provider-woocommerce-********************.js 657 B
./dist/assets/js/googlesitekit-events-provider-wpforms-********************.js 633 B
./dist/assets/js/googlesitekit-i18n-********************.js 3.93 kB
./dist/assets/js/googlesitekit-modules-********************.js 22 kB
./dist/assets/js/googlesitekit-modules-ads-********************.js 32.7 kB
./dist/assets/js/googlesitekit-modules-adsense-********************.js 123 kB
./dist/assets/js/googlesitekit-modules-analytics-4-********************.js 173 kB
./dist/assets/js/googlesitekit-modules-pagespeed-insights-********************.js 22.5 kB
./dist/assets/js/googlesitekit-modules-reader-revenue-manager-********************.js 21.9 kB
./dist/assets/js/googlesitekit-modules-search-console-********************.js 59.1 kB
./dist/assets/js/googlesitekit-modules-sign-in-with-google-********************.js 1.01 kB
./dist/assets/js/googlesitekit-modules-tagmanager-********************.js 32 kB
./dist/assets/js/googlesitekit-notifications-********************.js 22.4 kB
./dist/assets/js/googlesitekit-polyfills-********************.js 377 B
./dist/assets/js/googlesitekit-settings-********************.js 125 kB
./dist/assets/js/googlesitekit-splash-********************.js 86.4 kB
./dist/assets/js/googlesitekit-user-input-********************.js 60.8 kB
./dist/assets/js/googlesitekit-vendor-********************.js 321 kB
./dist/assets/js/googlesitekit-widgets-********************.js 89.1 kB
./dist/assets/js/googlesitekit-wp-dashboard-********************.js 62.1 kB
./dist/assets/js/runtime-********************.js 1.3 kB

compressed-size-action

Copy link
Collaborator

@nfmohit nfmohit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work, @hussain-t !

Note: I've verified that the failing tests in CI are unrelated to this PR and are addressed as part of other issues.

@nfmohit nfmohit merged commit beddde5 into develop Oct 2, 2024
17 of 21 checks passed
@nfmohit nfmohit deleted the enhancement/#7642-adsense-notification-ui-issues branch October 2, 2024 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants