Fix / 9156 Gate by Feature Flag #9454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build files for 177e36d have been deleted. |
|
Size Change: -12 B (0%) Total Size: 1.85 MB
ℹ️ View Unchanged
|
eugene-manuilov
requested changes
Oct 3, 2024
| @@ -412,6 +412,7 @@ const KEY_METRICS_WIDGETS = { | |||
| 'google-site-kit' | |||
| ), | |||
| requiredConversionEventName: [ 'add_to_cart' ], | |||
| displayInList: shouldDisplayWidgetWithConversionEvent, | |||
There was a problem hiding this comment.
@10upsimon, I suppose the idea here is to ensure that this widget doesn't appear when the conversionReporting feature flag is not enabled for the site, right? The problem is that the shouldDisplayWidgetWithCustomDimensions function doesn't check for that feature flag, hence this widget will continue appearing. Or I miss something?
There was a problem hiding this comment.
@eugene-manuilov the very first thing the function checks for is the feature flag?
if ( ! isFeatureEnabled( 'conversionReporting' ) ) {
return false;
}
There was a problem hiding this comment.
@eugene-manuilov That function checks for feture flag before checking for detected events
There was a problem hiding this comment.
Yeah, you are right guys. I looked at the wrong function. Looks good now.
eugene-manuilov
approved these changes
Oct 3, 2024
| @@ -412,6 +412,7 @@ const KEY_METRICS_WIDGETS = { | |||
| 'google-site-kit' | |||
| ), | |||
| requiredConversionEventName: [ 'add_to_cart' ], | |||
| displayInList: shouldDisplayWidgetWithConversionEvent, | |||
There was a problem hiding this comment.
Yeah, you are right guys. I looked at the wrong function. Looks good now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses issue:
Top cities driving add to cartACR KMW #9156Relevant technical choices
PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist