Add new notice components for both modules. #9460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build files for 5b48a20 have been deleted. |
|
Size Change: +1.1 kB (+0.06%) Total Size: 1.85 MB
ℹ️ View Unchanged
|
tofumatt
approved these changes
Oct 4, 2024
| <WithTestRegistry | ||
| features={ features } | ||
| route={ route } | ||
| // Expose registry as global for tinkering. |
There was a problem hiding this comment.
This is a great comment 😄
assets/js/modules/analytics-4/components/common/AccountCreate/index.test.js
Outdated
Show resolved
Hide resolved
| @@ -22,6 +22,10 @@ | |||
| margin-top: 0 !important; | |||
| } | |||
|
|
|||
| .googlesitekit-margin-top-1 { | |||
| margin-top: 1rem !important; | |||
There was a problem hiding this comment.
Usually when adding !important it's good to add a reason why we're using important. It helps with debugging/removals/auditing in the future.
I suspect the reason here is just to make sure these styles are always applied regardless of other classes—if that's the case I can add a comment for all of them.
There was a problem hiding this comment.
Yeah it's following the precedent here (which is inconsistent too), but if we're using a utility, it should be authoritative.
aaemnnosttv
commented
Oct 4, 2024
| @@ -22,6 +22,10 @@ | |||
| margin-top: 0 !important; | |||
| } | |||
|
|
|||
| .googlesitekit-margin-top-1 { | |||
| margin-top: 1rem !important; | |||
There was a problem hiding this comment.
Yeah it's following the precedent here (which is inconsistent too), but if we're using a utility, it should be authoritative.
| @@ -96,8 +122,6 @@ describe( 'SetupForm', () => { | |||
| .dispatch( MODULES_ANALYTICS_4 ) | |||
| .selectAccount( accountID ); | |||
|
|
|||
| registry.dispatch( MODULES_ANALYTICS_4 ).setAccountID( accountID ); | |||
There was a problem hiding this comment.
I cleaned up all of these where it was called after selectAccount which uses this internally and thus redundant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses issue:
Relevant technical choices
PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist