-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added AVX512 support for SkRasterPipeline_opts.h #149
base: main
Are you sure you want to change the base?
Conversation
This PR (HEAD: 488dccd) has been imported to Gerrit for code review. Please visit review.skia.org/779576 to see it. Please CC yourself to the Gerrit change. Note:
|
It looks like you have not signed the CLA. Please follow the steps at https://skia.org/docs/dev/contrib/#contribute-code . |
@pingladd I don't know if you've seen, but @johnstiles-google and I have been reviewing the change on Gerrit: https://skia-review.googlesource.com/c/skia/+/779235 The link in the earlier comment here goes to the wrong change - sorry about that. (I think our script for copying GitHub changes to Gerrit made two copies). I'd suggest continuing to work on the change via Gerrit (or consider just uploading a change directly there, rather than on GitHub). See https://skia.org/docs/dev/contrib/ for details. |
[AMD Official Use Only - General]
Hi Brian and John,
Thank you all for the comments. I will work on the changes via Gerrit.
Thanks,
Ping
From: Brian Osman ***@***.***>
Sent: Friday, November 17, 2023 10:01 AM
To: google/skia ***@***.***>
Cc: Wang, Ping ***@***.***>; Mention ***@***.***>
Subject: Re: [google/skia] Added AVX512 support for SkRasterPipeline_opts.h (PR #149)
Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
@pingladd<https://github.com/pingladd> I don't know if you've seen, but @johnstiles-google<https://github.com/johnstiles-google> and I have been reviewing the change on Gerrit: https://skia-review.googlesource.com/c/skia/+/779235
The link in the earlier comment here goes to the wrong change - sorry about that. (I think our script for copying GitHub changes to Gerrit made two copies). I'd suggest continuing to work on the change via Gerrit (or consider just uploading a change directly there, rather than on GitHub). See https://skia.org/docs/dev/contrib/ for details.
—
Reply to this email directly, view it on GitHub<#149 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AUS6H65PO5H5QTSM5A3QA3TYE6C4RAVCNFSM6AAAAAA7NHXHEWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMJWGY4DMNBYGA>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Hi, The patch has integrated AVX512 support for certain functions in both highp and lowp. Testing and verification were conducted within the Pdfium repository, where it passed the pdfium_embeddertests.exe. Performance-wise, the AVX512 code path shows significant enhancement over the standard SSE and AVX2 paths. This performance boost was confirmed through testing with PDF files sourced from the resources folder of the Pdfium library. This is an imported pull request from google#149 GitOrigin-RevId: 3dfeb3b Change-Id: I91f95a69d914ed57707239b7d2257a6c8f0c3ffa
Hi, The patch has integrated AVX512 support for certain functions in both highp and lowp. Testing and verification were conducted within the Pdfium repository, where it passed the pdfium_embeddertests.exe. Performance-wise, the AVX512 code path shows significant enhancement over the standard SSE and AVX2 paths. This performance boost was confirmed through testing with PDF files sourced from the resources folder of the Pdfium library. This is an imported pull request from google#149 GitOrigin-RevId: 3dfeb3b Change-Id: I91f95a69d914ed57707239b7d2257a6c8f0c3ffa This is an imported pull request from google#151 GitOrigin-RevId: 02db57e Change-Id: Ia674977e3c1a083938bbfda1e9d785595896cb88
Hi, The patch has integrated AVX512 support for certain functions in both highp and lowp. Testing and verification were conducted within the Pdfium repository, where it passed the pdfium_embeddertests.exe. Performance-wise, the AVX512 code path shows significant enhancement over the standard SSE and AVX2 paths. This performance boost was confirmed through testing with PDF files sourced from the resources folder of the Pdfium library. This is an imported pull request from google#149 GitOrigin-RevId: 3dfeb3b Change-Id: I91f95a69d914ed57707239b7d2257a6c8f0c3ffa This is an imported pull request from google#151 GitOrigin-RevId: 02db57e Change-Id: Ia674977e3c1a083938bbfda1e9d785595896cb88
Hi, The patch has integrated AVX512 support for certain functions in both highp and lowp. Testing and verification were conducted within the Pdfium repository, where it passed the pdfium_embeddertests.exe. Performance-wise, the AVX512 code path shows significant enhancement over the standard SSE and AVX2 paths. This performance boost was confirmed through testing with PDF files sourced from the resources folder of the Pdfium library. This is an imported pull request from google#149 GitOrigin-RevId: 3dfeb3b Change-Id: I91f95a69d914ed57707239b7d2257a6c8f0c3ffa This is an imported pull request from google#151 GitOrigin-RevId: 354e9e0 Change-Id: Ia674977e3c1a083938bbfda1e9d785595896cb88
Hi,
The patch has integrated AVX512 support for certain functions in both highp and lowp. Testing and verification were conducted within the Pdfium repository, where it passed the pdfium_embeddertests.exe. Performance-wise, the AVX512 code path shows significant enhancement over the standard SSE and AVX2 paths. This performance boost was confirmed through testing with PDF files sourced from the resources folder of the Pdfium library.