Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash rendering emoji on macOS with FontCollection that lacks def… #162

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tronical
Copy link

…ault font manager

FontCollection checks if fDefaultFontManager is non-null in various places before using it, except when determining the emoji fallback font. This can cause a crash when the FontCollection was not initialized with a default font manager.

This is reproducible for me on macOS with the 🍃 emoji.

…ault font manager

FontCollection checks if fDefaultFontManager is non-null in various
places before using it, except when determining the emoji fallback font.
This can cause a crash when the FontCollection was not initialized with
a default font manager.

This is reproducible for me on macOS with the 🍃 emoji.
Copy link

google-cla bot commented Feb 28, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@skia-codereview-bot
Copy link
Collaborator

This PR (HEAD: e59f016) has been imported to Gerrit for code review.

Please visit review.skia.org/819916 to see it. Please CC yourself to the Gerrit change.

Note:

  • Skia uses only Gerrit for reviews and submitting code (doc).
  • All comments are handled within Gerrit. Any comments on the GitHub PR will be ignored.
  • The PR author can continue to upload commits to the branch used by the PR in order to address feedback from Gerrit.
  • Once the code is ready to be merged, a maintainer will submit the change on Gerrit and skia-codereview-bot will close this PR.
  • Similarly, if a change is abandoned on Gerrit, the corresponding PR will be closed with a note.

tronical added a commit to slint-ui/slint that referenced this pull request Feb 28, 2024
Set a default font manager to avoid that the unconditional dereferencing inside Skia crashes on a null pointer.

Upstream PR: google/skia#162

Fixes #4696
tronical added a commit to slint-ui/slint that referenced this pull request Feb 28, 2024
Set a default font manager to avoid that the unconditional dereferencing inside Skia crashes on a null pointer.

Upstream PR: google/skia#162

Fixes #4696
tronical added a commit to slint-ui/slint that referenced this pull request Feb 29, 2024
Set a default font manager to avoid that the unconditional dereferencing inside Skia crashes on a null pointer.

Upstream PR: google/skia#162

Fixes #4696
tronical added a commit to slint-ui/slint that referenced this pull request Jun 3, 2024
While google/skia#162 has not been merged yet,
it's included in skia-safe:

rust-skia/rust-skia#986
tronical added a commit to slint-ui/slint that referenced this pull request Jun 3, 2024
While google/skia#162 has not been merged yet,
it's included in skia-safe:

rust-skia/rust-skia#986
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants