Fix bug in glue op #216
Merged
Fix bug in glue op #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianspektor
commented
Aug 10, 2023
| @@ -201,7 +201,7 @@ def glue( | |||
| Returns: | |||
| EventSet with concatenated features. | |||
| """ | |||
| if len(inputs) == 1: | |||
| if len(inputs) == 1 and isinstance(inputs[0], EventSetNode): | |||
There was a problem hiding this comment.
This fixes an unrelated bug which caused glue(literally anything) to return that same thing, discovered while passing glue(evset_list) instead of glue(*evset_list)
There was a problem hiding this comment.
Oh nice catch! I guess... that same bug is in combine() as well 😬
There was a problem hiding this comment.
Updated combine too
DonBraulio
reviewed
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sorted()in the glue implementation gave the wrong order when inputs >= 11, since "input_10" as a string is less than "input_2". remove the sorted since I don't think it's needed, else we'll need to change it for a custom sorted that takes this into account.