Upgrade to tensorflow 2.13 #407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage reportMain: 91.57% | PR: 91.57% | Diff: 0.00 ✅ |
achoum
reviewed
Mar 26, 2024
achoum
approved these changes
Mar 26, 2024
javiber
force-pushed
the
upgrade-tf-for-arm-macos
branch
from
153d4c7
to
e6bdfb5
Compare
javiber
force-pushed
the
upgrade-tf-for-arm-macos
branch
from
bda5196
to
d1598d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version 2.12 fails on arm-based macOS.
Changed
tool.poetry.dependenciesso that it still accepts 2.12 as well as any newer version (before 3.0). This makes our package more forgiving when our users try to install it with different versions of tensorflow.Notice that accepting 2.12 in these dependencies is not a problem because pip will solve correctly for a version that's compatible with the user's environment.
On
tool.poetry.group.dev.dependenciesI had to be more strict because when poetry locks the dependencies, it'd choose 2.12 (even on an arm environment where the package will fail)Closes #387