vendor/etcd: don't use now-removed deprecated methods #805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grpc/grpc-go#1392 has removed metadata.NewContext and metadata.FromContext, so (locally) change invocations in our vendored etcd code.
|
Drat, it looks like there are more problems in the |
Use a HEAD^ version that has both the old and new variants of the context methods to minimize knock-on changes.
|
Do you need to borrow a can opener? |
gdbelvin
approved these changes
Aug 18, 2017
Martin2112
approved these changes
Aug 18, 2017
|
These changes are tied to an upstream update in grpc-go (and we currently build against the tip of that repo) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
grpc/grpc-go#1392 has removed metadata.NewContext
and metadata.FromContext, so (locally) change invocations in our vendored etcd
code.