Enable a few more Guava Primitives tests for J2KT #1253
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_611416247
branch
from
9c15a9d
to
e3b4354
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable a few more Guava Primitives tests for J2KT
some Base regex helpers have become available for J2KT since last iteration. Thanks cpovirk@ for pointing this out
there was a transpiler improvement:
GREATEST - (short) 1is a compile time constant in Java and can be used toinitialize a
shortbecause the compiler can verify that the value is smallenough. The straight-forward translation
GREATEST - 1.toShort()is not acompile time constant in Kotlin and cannot be used to initialize a
Short. Thetranspiler handles this now
RELNOTES=n/a