This repository has been archived by the owner on Dec 29, 2022. It is now read-only.
Clients: require source match to differentiate between different iframes of the same origin #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mes of the same origin
kaipakartik
reviewed
Aug 16, 2018
kaipakartik
reviewed
Aug 16, 2018
| origin: 'https://example-sp.com', | ||
| source, |
There was a problem hiding this comment.
Where is this source variable set?
Shouldn't you have two sources to actually have a test for an iframe?
There was a problem hiding this comment.
The main source var is set up in the beforeEach of the test. The failure is also tested below - it's the one with the anotherSource var.
|
@kaipakartik Our example is actually slightly hybrid: there are no cases with two iframes running at the same time - instead we destroy the previous iframe slightly later, after the next iframe has been initialized to reduce visual issues. So, they overlap by about 1s. Two iframes running at the same time, however, is not a very bizarre notion - though not the most typical case. |
kaipakartik
approved these changes
Aug 16, 2018
|
Thanks for the clarifications. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current origin check is necessary, but not sufficient. This PR also adds
event.sourcecheck on the client side to disambiguate between two iframes with the same origin. With popups such a case is a lot less likely, but for posterity the same check is added for that mode as well.