Optimize Miri for test_validate_cast_and_convert_metadata
#397
Comments
joshlf
added a commit
that referenced
this issue
Sep 19, 2023
In #376, we introduced `test_validate_rust_layout`, which took a long time to run under Miri. In order to prevent it from consuming too much time in CI, we marked it as `#[cfg_attr(miri, ignore)]`, and configured CI to pass `-- --ignored` to Miri only a small percentage of the time. This had the unintended side effect of running `test_validate_cast_and_convert_metadata` under Miri. That test is marked as `#[cfg_attr(miri, ignore)]` for good reason - it takes far too long to run under Miri, and doesn't exercise any `unsafe` code, so doesn't benefit from Miri. Enabling this test has caused CI to timeout. In the interim, in #395, we optimized `test_validate_rust_layout` so that it no longer takes an unreasonably long time to run under Miri. Thus, in this commit, we remove the `#[cfg_attr(miri, ignore)]` annotation from that test, and no longer pass `-- --ignored` to Miri in CI. Closes #397
joshlf
added a commit
that referenced
this issue
Sep 19, 2023
In #376, we introduced `test_validate_rust_layout`, which took a long time to run under Miri. In order to prevent it from consuming too much time in CI, we marked it as `#[cfg_attr(miri, ignore)]`, and configured CI to pass `-- --ignored` to Miri only a small percentage of the time. This had the unintended side effect of running `test_validate_cast_and_convert_metadata` under Miri. That test is marked as `#[cfg_attr(miri, ignore)]` for good reason - it takes far too long to run under Miri, and doesn't exercise any `unsafe` code, so doesn't benefit from Miri. Enabling this test has caused CI to timeout. In the interim, in #395, we optimized `test_validate_rust_layout` so that it no longer takes an unreasonably long time to run under Miri. Thus, in this commit, we remove the `#[cfg_attr(miri, ignore)]` annotation from that test, and no longer pass `-- --ignored` to Miri in CI. Closes #397
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently, Miri tests are failing (both on main and in PRs) due to
test_validate_cast_and_convert_metadatataking too long to run. We need to optimize this under Miri to unblock CI.The text was updated successfully, but these errors were encountered: