-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move padding checks into derive_util
macros
#113
Conversation
5cdb1f5
to
19cc619
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks awesome! Thanks so much for doing this! A few small comments inline, but also: It looks like the new code generates padding errors during an earlier compiler pass than most of the other errors (at least that's my guess as to why many errors are removed in this diff). Could you split up the UI test source files so that we still get test coverage for those errors?
The
So it looks like enabling |
Yeah let's stick to the hack; it's pretty minor, and that's a lot of compilation time to add. |
Looks like this wasn't addressed yet - just a heads up in case you're waiting for a review on the latest changes. If you were planning on addressing this later, then just disregard this comment. |
fe18a9b
to
002b6b0
Compare
Move the padding checks into macros in a new `derive_util` module and emit implementations with an additional `where` clause. Closes #109 Co-authored-by: David Koloski <[email protected]>
This moves the padding checks into macros in a new
derive_util
module and emits implementations with an additional where clause. Some of the proposed names from #109 has been slightly changed to make the emitted error messages more understandable: