Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add toolchain cfg for testing msrv #1515

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

djkoloski
Copy link
Member

Also renames __INTERNAL_USE_ONLY_NIGHTLY_FEATURES_IN_TESTS to __ZEROCOPY_INTERNAL_USE_ONLY_NIGHTLY_FEATURES_IN_TESTS for consistency.

@codecov-commenter
Copy link

codecov-commenter commented Jul 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.70%. Comparing base (2ceabfe) to head (6c7b8be).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1515   +/-   ##
=======================================
  Coverage   87.69%   87.70%           
=======================================
  Files          15       15           
  Lines        5560     5563    +3     
=======================================
+ Hits         4876     4879    +3     
  Misses        684      684           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

tools/cargo-zerocopy/src/main.rs Outdated Show resolved Hide resolved
@djkoloski djkoloski force-pushed the add_toolchain_cfg branch 2 times, most recently from 0bb8ac9 to 523aee2 Compare July 12, 2024 22:58
@djkoloski djkoloski requested a review from joshlf July 12, 2024 23:04
Copy link
Member

@joshlf joshlf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you squash this into one commit?

@djkoloski djkoloski added this pull request to the merge queue Jul 16, 2024
Merged via the queue into google:main with commit 1336f4b Jul 16, 2024
77 checks passed
@djkoloski djkoloski deleted the add_toolchain_cfg branch July 16, 2024 16:05
djkoloski added a commit that referenced this pull request Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants